doveadm-http: Correctly initialize parameters

dovecot · Feb 21, 2016 · b4a7ea6 · b4a7ea6
1 parent f169d42
commit b4a7ea6
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/doveadm/client-connection-http.c b/src/doveadm/client-connection-http.c
@@ -373,10 +373,13 @@ doveadm_http_server_read_request(struct client_connection_http *conn)
 				conn->json_state = JSON_STATE_COMMAND_ID;
 				conn->method_err = 404;
 			} else {
-			        const struct doveadm_cmd_param *cpar;
+			        struct doveadm_cmd_param *param;
 				/* initialize pargv */
-				for(cpar = conn->cmd->parameters; cpar->name != NULL; cpar++)
-					array_append(&conn->pargv, cpar, 1);
+				for(int pargc=0;conn->cmd->parameters[pargc].name != NULL;pargc++) {
+					param = array_append_space(&conn->pargv);
+					memcpy(param, &(conn->cmd->parameters[pargc]), sizeof(struct doveadm_cmd_param));
+					param->value_set = FALSE;
+				}
 				conn->json_state = JSON_STATE_COMMAND_PARAMETERS;
 			}
 		} else if (conn->json_state == JSON_STATE_COMMAND_PARAMETERS) {