Skip to content

Commit

Permalink
dict-client: When failing to resend commands after reconnect, their s…
Browse files Browse the repository at this point in the history
…uccess is uncertain.

It's possible that the writes before the disconnection did actually finish
successfully. If any of them were commits, we need to return
DICT_COMMIT_RET_WRITE_UNCERTAIN.
  • Loading branch information
sirainen committed Jan 10, 2017
1 parent aed6c42 commit d165b70
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/lib-dict/dict-client.c
Expand Up @@ -346,7 +346,7 @@ client_dict_cmd_send(struct client_dict *dict, struct client_dict_cmd **_cmd,
} else if (ret < 0) {
i_assert(error != NULL);
/* we didn't successfully send this command to dict */
dict_cmd_callback_error(cmd, error, FALSE);
dict_cmd_callback_error(cmd, error, cmd->reconnected);
client_dict_cmd_unref(cmd);
if (error_r != NULL)
*error_r = error;
Expand Down

0 comments on commit d165b70

Please sign in to comment.