Skip to content

Commit

Permalink
lib-sieve: redirect command: Removed useless NULL check in loop detec…
Browse files Browse the repository at this point in the history
…tion.

This caused a coverity defect report.
  • Loading branch information
stephanbosch committed Apr 26, 2016
1 parent ef25ce6 commit 504a08a
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions src/lib-sieve/cmd-redirect.c
Expand Up @@ -441,7 +441,7 @@ static int act_redirect_commit
const struct sieve_message_data *msgdata = aenv->msgdata;
const struct sieve_script_env *senv = aenv->scriptenv;
const char *msg_id = msgdata->id, *new_msg_id = NULL;
const char *dupeid = NULL, *resent_id = NULL;
const char *dupeid, *resent_id = NULL;
const char *list_id = NULL;
const char *recipient;
int ret;
Expand Down Expand Up @@ -511,10 +511,8 @@ static int act_redirect_commit
(aenv, mail, ctx, new_msg_id)) == SIEVE_EXEC_OK) {

/* Mark this message id as forwarded to the specified destination */
if (dupeid != NULL) {
sieve_action_duplicate_mark(senv, dupeid, strlen(dupeid),
ioloop_time + CMD_REDIRECT_DUPLICATE_KEEP);
}
sieve_action_duplicate_mark(senv, dupeid, strlen(dupeid),
ioloop_time + CMD_REDIRECT_DUPLICATE_KEEP);

sieve_result_global_log(aenv, "forwarded to <%s>",
str_sanitize(ctx->to_address, 128));
Expand Down

0 comments on commit 504a08a

Please sign in to comment.