Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if data in series is string but in dateformat #37

Closed
4 tasks done
galbraun opened this issue Oct 25, 2019 · 4 comments · Fixed by #94
Closed
4 tasks done

Check if data in series is string but in dateformat #37

galbraun opened this issue Oct 25, 2019 · 4 comments · Fixed by #94
Labels
_Hints adding new hook
Milestone
alpha

Comments

@galbraun
Copy link
Collaborator

galbraun commented Oct 25, 2019 •
edited by DeanLa
Loading

Basic Functionality

Check after a Series or Dataframe creation and after addition of a new column if the data look like datetime but in a different dtype.

Hooks Upon

  • Series / Dataframe creation functions
  • assign
  • insert
  • _setitem

Hook Type

per-hook

Design

check that the data inserted into the structure is with date structure (with the help of python-dateutil), if the dtype is not date - suggest using pandas.to_datetime()
@galbraun galbraun added the _Hints adding new hook label Oct 25, 2019
@DeanLa
Copy link
Member

DeanLa commented Oct 25, 2019

Maybe also should hook upon read methods?

@DeanLa
Copy link
Member

DeanLa commented Oct 25, 2019

We should make the option for same function to hook several functions.

@DeanLa
Copy link
Member

DeanLa commented Oct 25, 2019

addressed in #39

@DeanLa DeanLa added this to the alpha milestone Oct 25, 2019
@DeanLa DeanLa mentioned this issue Nov 3, 2019
Closed
@DeanLa
Copy link
Member

DeanLa commented Nov 15, 2019

On it

DeanLa added a commit that referenced this issue Nov 15, 2019
@DeanLa
check for time dtype
12a0152 
closes #37

 on __setitem__
 on assign
@DeanLa DeanLa mentioned this issue Nov 15, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
_Hints adding new hook
Projects
None yet
Milestone
alpha
Development

Successfully merging a pull request may close this issue.

Suggest todatetime assign and __setitem__ dovpanda-dev/dovpanda
2 participants
@DeanLa @galbraun