Feature/quarantine issues list #116
Conversation
Update with Quarantine list feature changes
Updated quarantine issue changes.
Updated with quarantine list changes.
Updated with Temp whitlist item changes.
|
|
||
| comment = (f"CloudTrail logging issue with '{region}' " | ||
| f"in '{account_name} / {account_id}' account is added to temporary whitelist.") | ||
| jira.update_issue( |
There was a problem hiding this comment.
Will this message be posted to jira for the same issue multiple times (on each reporting phase)?
There was a problem hiding this comment.
I don't think we should add this message more than once, at least we shouldn't add it if nothing is changed.
Updated with review comments.
Updated with review comments.
Updated tempwhitelist issue changes.
| @@ -41,6 +41,12 @@ def cleans3bucketunencrypted(self, batch=False): | |||
|
|
|||
| in_whitelist = self.config.s3Encrypt.in_whitelist(account_id, bucket_name) | |||
| in_fixlist = True | |||
| in_temp_whitelist = self.config.s3Encrypt.in_temp_whitelist(account_id, issue.issue_id) | |||
| if in_temp_whitelist: | |||
There was a problem hiding this comment.
This check not required because of method get_account_open_issues return just open issues, so tmpwhitelisted won't be on the list.
There was a problem hiding this comment.
check this below scenario:
Issue Identified. And issue added to temp-whitelisted,
now remediation calls, here we are not checking the Issue status, instead we are checking tempwhitelist json, if issue found in json, we are skipping this. Plz check and let me know.
| bu=bu, product=product, | ||
| ) | ||
| IssueOperations.set_status_temp_whitelisted(ddb_table, issue) | ||
| elif issue.status in [IssueStatus.Resolved, IssueStatus.Whitelisted]: |
There was a problem hiding this comment.
Create a new ticket without comment, that ticket is temporary whitelisted.
Description contains "Auto-Remediation Date: 2019-10-18"
Ticket#6352
There was a problem hiding this comment.
Agreed and will update changes. Comment will add in next iteration of reporting calls after ticket creation. For Auto-remediation date will add conditional block.
Updated with review comments.
Updated with review comments.
Added quarantine issues feature list.