Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proptype issue #40

Closed
MajidDehnamaki opened this issue Jan 30, 2018 · 7 comments
Closed

proptype issue #40

MajidDehnamaki opened this issue Jan 30, 2018 · 7 comments
Labels
need more info

Comments

@MajidDehnamaki
Copy link

hi
at the first better u know I'm new at the react
I use this but see this error
Calling PropTypes validators directly is not supported by the prop-types package. Use PropTypes.checkPropTypes() to call them.
@mrchief
Copy link
Collaborator

mrchief commented Jan 30, 2018

@MajidDehnamaki Where do you see the error? Are you sure its not coming from one of your own code? Can you provide some code (or a small repo that reproduces this error)?

@MajidDehnamaki
Copy link
Author

@mrchief
this warning came from main file of this component code
its come from react-dropdown-tree-select.js file

@mrchief
Copy link
Collaborator

mrchief commented Jan 31, 2018 •
edited
Loading

@MajidDehnamaki I would need a repo which reproduces this.

I don't see that warning on my side when I run the tests or builds or my projects or any codesandbox examples.

@toofff
Copy link
Contributor

toofff commented Feb 8, 2018 •
edited
Loading

Hello @mrchief,

I have the same problem with React 16.2 and typescript.

@mrchief
Copy link
Collaborator

mrchief commented Feb 8, 2018

Can I see a repo to reproduce this?

@mrchief
Copy link
Collaborator

mrchief commented Feb 9, 2018

@MajidDehnamaki @toofff Is this what you're seeing?

image

If so, this is not an issue coming from this component. It's emitted by react-simple-dropdown which this package depends on. That package hasn't been updated to use React 16 yet. However, this warning shouldn't affect anything runtime.

I do have a branch which eliminates this dependency but I haven't been able to test it thoroughly yet. If this warning bothers you, I would love to get some help on getting this branch tested and released.

mrchief added a commit that referenced this issue Feb 11, 2018
@mrchief
refactor(core-ui): Removed dependency on react-simple-dropdown package 🔨
6f280b9 
- Slims down bundle size
- Removes warnings associated with react-simple-dropdown package

Fixes #40
mrchief added a commit that referenced this issue Feb 14, 2018
@mrchief
feat(ui): Remove dependency on react-simple-dropdown package (#45) ✨
bbd5c2c 
refactor(ui): Removed dependency on react-simple-dropdown package

- Slims down bundle size
- Removes warnings associated with react-simple-dropdown package

* perf: V8 Perf tweak 🐎

* docs(README): Updated CSS skeleton to reflect react-simple-dropdown package removal related changes 📚

Fixes #40
@Gregcop1
Copy link
Contributor

Oh nice. We were stucked with this @mrchief . Thanks for your hard work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
need more info
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mrchief @toofff @Gregcop1 @MajidDehnamaki