Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add types friendly badge 馃摎 #229

Merged
merged 3 commits into from
Apr 13, 2019
Merged

docs: Add types friendly badge 馃摎 #229

merged 3 commits into from
Apr 13, 2019

Conversation

mrchief
Copy link
Collaborator

@mrchief mrchief commented Mar 31, 2019

What does it do?

Adds a "types (friendly) badge" to Readme

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@mrchief mrchief changed the title Typescript badge docs: Add types friendly badge 馃摎 Mar 31, 2019
@coveralls
Copy link

coveralls commented Mar 31, 2019

Pull Request Test Coverage Report for Build 980

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.862%

Totals Coverage Status
Change from base Build 975: 0.0%
Covered Lines: 325
Relevant Lines: 335

馃挍 - Coveralls

@codeclimate
Copy link

codeclimate bot commented Apr 3, 2019

Code Climate has analyzed commit 6952b10 and detected 0 issues on this pull request.

View more on Code Climate.

@ellinge
Copy link
Collaborator

ellinge commented Apr 4, 2019

I'll leave it to you to merge. I'll guess it will work when types are present in the master branch (says none now).

@mrchief
Copy link
Collaborator Author

mrchief commented Apr 5, 2019

I'll guess it will work when types are present in the master branch (says none now).

It'll work (or so I hope) after we publish the package with types. I think we should. I know you wanted to hold off the release given how we lack typings right now, I don't think it'll be a big issue though.

@mrchief mrchief merged commit 5036651 into develop Apr 13, 2019
@mrchief mrchief deleted the typescript-badge branch April 13, 2019 15:34
mrchief added a commit that referenced this pull request Apr 18, 2019
## What does it do?

Adds a "types (friendly) badge" to Readme

## Type of change

Please delete options that are not relevant.

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [X] This change requires a documentation update
@mrchief
Copy link
Collaborator Author

mrchief commented Jun 10, 2019

馃帀 This PR is included in version 2.0.0 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants