refactor: Update mode to include hierarchical

[mrchief]

BREAKING: hierarchical prop

hierarchical prop is now moved under mode prop.

// before
<DropdownTreeSelect data={data} hierarchical={true} />

// after
<DropdownTreeSelect data={data} mode="hierarchical" />

[coveralls]

Pull Request Test Coverage Report for Build 1159

• 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 94.315%

---

Totals
Change from base Build 1151:	0.0%
Covered Lines:	566
Relevant Lines:	581

---

💛 - Coveralls

[ellinge]

Just checked on my mobile. Will check further later. Looks good 👍 You need to update the story for options.

Should we do something about showShopdown, shopDropdownAlways.
What about oneOf(true, false, 'always') or something breaking for true/false as well.

The options tree/search props (keep*) could be bundled also? Perhaps one should not go over the top though with the bundling. Thoughts?

[ellinge]

Should be alright I we don't see anything else to bundle, but we could do that in a separate PR instead.

[mrchief]

The options tree/search props (keep*) could be bundled also? Perhaps one should not go over the top though with the bundling. Thoughts?

I concur. I don't see anything else as a natural candidate for bundling.

Should be alright I we don't see anything else to bundle, but we could do that in a separate PR instead.

Agreed. The showDropdown bundling will be a separate PR. Thinking about showDropdown: 'initial' | 'always'

Good catch about updating the Options story. Will do that.

[mrchief]

@ellinge Do you know if we absolutely need the semis in the .ts file? Prettier keeps removing them and I'm not sure if that's an error.

[mrchief]

This uses a mix of semis, commas, and no semis and doesn't seem to cause any syntax errors. According to this old issue, semis are optional too. If so, we can let prettier loose and strip the semis. Thoughts?

[ellinge]

Go ahead and strip them. I think we’ll be just fine and concistent.

[codeclimate]

Code Climate has analyzed commit 8f84986 and detected 0 issues on this pull request.

View more on Code Climate.

[ellinge]

Still works great within vs code if that was what you intended me to verify after dismissing my review.

[mrchief]

Still works great within vs code if that was what you intended me to verify after dismissing my review.

There's a GitHub setting that auto dismisses previous reviews if you push new commits. :)