Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: IE11 doesn't support Array.findIndex #348

Merged
merged 3 commits into from
Mar 28, 2020
Merged

fix: IE11 doesn't support Array.findIndex #348

merged 3 commits into from
Mar 28, 2020

Conversation

smurfs2549
Copy link
Contributor

@smurfs2549 smurfs2549 commented Mar 26, 2020 •
edited by mrchief

What does it do?

resolved findIndex() method issue can't support on internet explorer,

Fixes # (issue)

Fixes #347

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes
  • My changes generate no new warnings

@codeclimate
Copy link

codeclimate bot commented Mar 26, 2020

Code Climate has analyzed commit d6f263a and detected 0 issues on this pull request.

View more on Code Climate.

@coveralls
Copy link

coveralls commented Mar 26, 2020 •
edited

Pull Request Test Coverage Report for Build 1356

  • 10 of 11 (90.91%) changed or added relevant lines in 2 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-1.0%) to 94.162%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/tree-manager/keyboardNavigation.js 5 6 83.33%
Files with Coverage Reduction New Missed Lines %
src/tree-manager/keyboardNavigation.js 5 82.2%
Totals Coverage Status
Change from base Build 1352: -1.0%
Covered Lines: 596
Relevant Lines: 615
💛 - Coveralls

mrchief
mrchief approved these changes Mar 28, 2020
View reviewed changes
Copy link
Collaborator

@mrchief mrchief left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this!

@mrchief mrchief changed the title fixed IE can't support findIndex method issue fix: IE11 doesn't support Array.findIndex Mar 28, 2020
@mrchief mrchief merged commit a2d754f into dowjones:develop Mar 28, 2020
@mrchief
Copy link
Collaborator

mrchief commented Mar 29, 2020

🎉 This PR is included in version 2.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mrchief mrchief mentioned this pull request Mar 29, 2020
Closed
m4theushw pushed a commit to m4theushw/react-dropdown-tree-select that referenced this pull request Sep 20, 2020
@smurfs2549 @m4theushw
fix: IE11 doesn't support Array.findIndex (dowjones#348)
813c068 
* fixed IE can't support findIndex method issue

* Update keyboardNavigation.js

update

* Update index.js

Co-authored-by: KathleenLu <kathleenlu@Objectivasoftware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrchief mrchief mrchief approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

findIndex method can't support on IE browser
3 participants
@smurfs2549 @coveralls @mrchief