fix: Remove search-specific properties from nodes on clear

[MJRuskin]

What does it do?

The "_isMatch" property is never cleared, so non-matching parents will still be shown (not greyed-out) and can be focused (i.e. navigation with the arrow keys)..

This fixes that issue by setting all parents to hidden, unless they themselves are a match. They will still be shown with keepTreeOnSearch, because the "matchInChildren" property is set to true.

Fixes # (issue)

No issueNumber

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• Updated documentation (if applicable)
• Added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• My changes generate no new warnings

[coveralls]

Pull Request Test Coverage Report for Build 1366

• 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.02%) to 93.787%

---

Totals
Change from base Build 1363:	0.02%
Covered Lines:	596
Relevant Lines:	618

---

💛 - Coveralls

[MJRuskin]

There is likely a more elegant way to resolve this problem, but this was the least intrusive code I could think of.

[MJRuskin]

Apologies for the force push, it seems like my previous version wasn't a complete fix. I have identified the issue properly, it is caused by the "_isMatch" property, and have created a better solution.

[codeclimate]

Code Climate has analyzed commit 55320e3 and detected 0 issues on this pull request.

View more on Code Climate.

[mrchief]

Hey, thanks for sending this. I'll look into it and get it merged soon.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[MJRuskin]

@mrchief any chance we could reopen this?

[mrchief]

Yes, sorry. This shouldn't have gotten closed.

[mrchief]

Not able to reopen it, probably because of this?

[MJRuskin]

Ah... damn...
I merged in the changes from develop, originally hoping it would remove the stale tag.
I guess it didn't update like the open branches

[MJRuskin]

I returned the branch to its original state (before the merge).
Let me know if that fixes the issue.

If not, I will recreate the PR (lesson learned!)

[mrchief]

:) Reopen is still disabled.

[MJRuskin]

@mrchief apologies for the hassle, I've reopened the PR here #377