-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Clear partial status of previous radio select parents #373
Conversation
Pull Request Test Coverage Report for Build 1373
💛 - Coveralls |
@MJRuskin thanks for sending this. This looks good but can we add a test for this condition as well? |
Code Climate has analyzed commit 425270d and detected 0 issues on this pull request. View more on Code Climate. |
@mrchief I just added some tests, including one for the special case I previously commented on in the code. Please let me know if anything else needs changing/fixing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for sending this!
Thanks for merging! :) |
🎉 This PR is included in version 2.3.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What does it do?
Clears the partial status from the parents of the previous node, when using radioSelect.
Fixes # (issue)
Fixes #372
Type of change
Please delete options that are not relevant.
Checklist: