Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clear partial status of previous radio select parents #373

Merged
merged 3 commits into from
May 25, 2020

Conversation

MJRuskin
Copy link
Contributor

@MJRuskin MJRuskin commented May 11, 2020

What does it do?

Clears the partial status from the parents of the previous node, when using radioSelect.

Fixes # (issue)

Fixes #372

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • Updated documentation (if applicable)
  • Added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My changes generate no new warnings

@coveralls
Copy link

coveralls commented May 11, 2020

Pull Request Test Coverage Report for Build 1373

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 93.985%

Totals Coverage Status
Change from base Build 1363: 0.2%
Covered Lines: 599
Relevant Lines: 620

💛 - Coveralls

@mrchief
Copy link
Collaborator

mrchief commented May 11, 2020

@MJRuskin thanks for sending this. This looks good but can we add a test for this condition as well?

@codeclimate
Copy link

codeclimate bot commented May 21, 2020

Code Climate has analyzed commit 425270d and detected 0 issues on this pull request.

View more on Code Climate.

@MJRuskin
Copy link
Contributor Author

@mrchief I just added some tests, including one for the special case I previously commented on in the code.
(apologies for the long test name, I wasn't sure how else to describe it)

Please let me know if anything else needs changing/fixing.

Copy link
Collaborator

@mrchief mrchief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for sending this!

@mrchief mrchief merged commit 02491b5 into dowjones:develop May 25, 2020
@MJRuskin
Copy link
Contributor Author

Thanks for merging! :)

@MJRuskin MJRuskin deleted the fix/partial-radios branch May 25, 2020 03:48
@mrchief
Copy link
Collaborator

mrchief commented May 31, 2020

🎉 This PR is included in version 2.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

m4theushw pushed a commit to m4theushw/react-dropdown-tree-select that referenced this pull request Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Partial status of radio select parents is not cleared when selecting a new radio option
3 participants