fix for push_approval method and test

dowjones · Oct 19, 2023 · f588bd4 · f588bd4
1 parent 1b137ac
commit f588bd4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/tests/unit/test_okta.py b/tests/unit/test_okta.py
@@ -299,7 +299,7 @@ def test_push_approval(mocker, return_value, side_effect, expected):
     mock_response.json = Mock(return_value=return_value)
 
     # Mocks
-    mocker.patch.object(HTTP_client, "post", return_value=mock_response, side_effect=side_effect)
+    mocker.patch.object(HTTP_client, "post", return_value=return_value, side_effect=side_effect)
     mocker.patch("time.sleep", return_value=0)
 
     try:

diff --git a/tokendito/okta.py b/tokendito/okta.py
@@ -483,7 +483,7 @@ def mfa_provider_type(
             logger.error(f"There was an error with the call to {mfa_challenge_url}: {err}")
             sys.exit(1)
     elif mfa_provider == "OKTA" and factor_type == "push":
-        mfa_verify = push_approval(headers, mfa_challenge_url, payload)
+        mfa_verify = push_approval(mfa_challenge_url, payload)
     elif mfa_provider in ["OKTA", "GOOGLE"] and factor_type in ["token:software:totp", "sms"]:
         mfa_verify = totp_approval(
             config, selected_mfa_option, headers, mfa_challenge_url, payload, primary_auth
@@ -649,7 +649,7 @@ def push_approval(mfa_challenge_url, payload):
     headers = {"content-type": "application/json", "accept": "application/json"}
 
     while status == "MFA_CHALLENGE" and result == "WAITING":
-        response = HTTP_client.post(mfa_challenge_url, json=payload, headers=headers).json()
+        response = HTTP_client.post(mfa_challenge_url, json=payload, headers=headers)
         if "sessionToken" in response:
             user.add_sensitive_value_to_be_masked(response["sessionToken"])