-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker support #112
Add docker support #112
Conversation
@sevignyj - If I'm reading the error correctly, the linting is upset about 3 files that I didn't change in this branch but yet the build succeeds in |
It looks like the code coverage report is showing a decrease in coverage on files that were not modified by this PR. |
Hi @opis-mark , this is due to the PR being from the fork. We increased the threshold in coveralls to address that, your next push should not trigger a failure. In the future we will change the test coverages to not run on non-code change. Really awesome PR, thank you so much @opis-mark ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you @opis-mark
Description
Add docker files to eliminate the installation and dependency requirements to have a working environment for tokendito.
Motivation and Context
I use containers for all of my python applications to avoid managing multiple python versions, dependencies, and virtual environments.
How Has This Been Tested?
I tested building and running the application with expected results.
Types of changes
Checklist: