Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with nested directories #121

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Fix issue with nested directories #121

merged 1 commit into from
Mar 7, 2023

Conversation

pcmxgti
Copy link
Contributor

@pcmxgti pcmxgti commented Mar 6, 2023

Description

Fixes a problem where Tokendito would fail to create intermediate
directories when running via a container with mounted volumes.

Related Issue

Motivation and Context

How Has This Been Tested?

With tox and a locally built container

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pcmxgti pcmxgti requested a review from sevignyj March 6, 2023 20:05
@pcmxgti pcmxgti marked this pull request as ready for review March 6, 2023 20:39
Fixes a problem where Tokendito would fail to create intermediate
directories when running via a container with mounted volumes.
Copy link
Contributor

@sevignyj sevignyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sevignyj sevignyj merged commit a102b14 into main Mar 7, 2023
@pcmxgti pcmxgti deleted the fix/mkdir branch March 7, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants