Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/requests #135

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Fix/requests #135

merged 1 commit into from
Oct 24, 2023

Conversation

fsilvamaia
Copy link
Contributor

@fsilvamaia fsilvamaia commented Sep 28, 2023 •
edited

Description

Create httpClient class with unit and functional tests and implements it in all necessary methods

Related Issue

Motivation and Context

How Has This Been Tested?

pytest tests/test_http_client.py
pytest tests/functional_test_http_client.py
E2E

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@fsilvamaia fsilvamaia marked this pull request as ready for review October 3, 2023 20:06
@fsilvamaia fsilvamaia force-pushed the fix/requests branch 3 times, most recently from 9a02c2e to 29be467 Compare October 23, 2023 18:27
pcmxgti
pcmxgti approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@pcmxgti pcmxgti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! - please squash your commits so that we can merge to main

@sevignyj sevignyj merged commit d3e2e35 into main Oct 24, 2023
23 checks passed
@pcmxgti pcmxgti deleted the fix/requests branch October 27, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcmxgti pcmxgti pcmxgti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fsilvamaia @pcmxgti @sevignyj