Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OIE tests #146

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Add OIE tests #146

merged 1 commit into from
Nov 28, 2023

Conversation

sevignyj
Copy link
Contributor

@sevignyj sevignyj commented Nov 19, 2023 •
edited by pcmxgti

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@sevignyj sevignyj force-pushed the fix/oie branch 2 times, most recently from 998c29c to 7c3648a Compare November 26, 2023 03:45
@sevignyj sevignyj changed the title WIP: fix OIE Add OIE tests Nov 26, 2023
@sevignyj sevignyj marked this pull request as ready for review November 26, 2023 04:18
pcmxgti
pcmxgti reviewed Nov 27, 2023
View reviewed changes
Copy link
Contributor

@pcmxgti pcmxgti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is an initial review. Let's go over it together and discuss my suggestions.

tokendito/http_client.py Outdated Show resolved Hide resolved
tokendito/okta.py Show resolved Hide resolved
tokendito/okta.py Show resolved Hide resolved
tokendito/okta.py Outdated Show resolved Hide resolved
tokendito/okta.py Outdated Show resolved Hide resolved
tokendito/okta.py Show resolved Hide resolved
@sevignyj sevignyj force-pushed the fix/oie branch 5 times, most recently from 702f90e to e2e1a9a Compare November 28, 2023 03:02
@pcmxgti pcmxgti self-assigned this Nov 28, 2023
pcmxgti
pcmxgti approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@pcmxgti pcmxgti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pcmxgti pcmxgti merged commit 66257b7 into main Nov 28, 2023
23 checks passed
@pcmxgti pcmxgti deleted the fix/oie branch November 28, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcmxgti pcmxgti pcmxgti approved these changes

Assignees

@pcmxgti pcmxgti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sevignyj @pcmxgti