Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a default username that persists across games when set #300

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

zhiyi-zhang-duke
Copy link
Contributor

@zhiyi-zhang-duke zhiyi-zhang-duke commented Dec 16, 2023

This code change adds a default_username to the localStorage that is only set when the user updates their username to something that is not a randomly generated name. This value is then checked when other games are loaded and if it is set, is used instead of the randomly generated name.

Here's the state of local storage after a new game is created:
image

Here's the state of local storage after the username is updated:
image

Here's the state of a new game after the username_default is set:
image

Copy link

vercel bot commented Dec 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
downforacross.com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2023 5:12am

Copy link

sweep-ai bot commented Dec 16, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@stevenhao
Copy link
Member

looks good!

@stevenhao stevenhao merged commit 71e3432 into downforacross:master Dec 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants