Skip to content

Commit

Permalink
feat(2.0.0): squashed commits of everything!
Browse files Browse the repository at this point in the history
fix(TypeScript): Change typings (#373)

BREAKING CHANGE: TypeScript typings are much more complete now.

fix(exports): removed statics assignments to default export (#390)

fix(build): to facilitate better tree-shaking, this is necessary

feat(a11y): Improve a11y and add getMenuProps (#285)

We no longer will validate your `htmlFor` and `id` attributes on labels
and inputs. Instead we provide props you can pass if you really want to
set those. You can still set those values yourself on the elements, but
we wont validate them for you.

Closes #283

fix(TypeScript): add missing types for setItemCount and unsetItemCount actions (#393)

fix(TS): add missing types for setState and getMenuProps (#394)

fix(aria): improve WAI-ARIA compliance (#396)

Big thanks to @1Copenut for leaving feedback in #285

fix(aria): remove unnecessary aria-expanded from the input

feat(flow): add flow definitions (#399)

* [#23] Flow definitions

* removed factory function

* Fix code review notes

fix(TypeScript): fix several type definitions (#407)

* Fixed existing types and added missing types

* Added Partial to state

Closes #406

fix(TS): Change StateChangeOptions to only extend DownshiftState as a Partial (#424)

* let prettier run

* Add contributor

* StateChangeOptions now extends only a Partial of DownshiftState

fix(flow): more precise types (#402)

* [#23] more precise types

* update defintions
  • Loading branch information
stereobooster authored and Kent C. Dodds committed Jun 11, 2018
1 parent b177475 commit b003097
Show file tree
Hide file tree
Showing 29 changed files with 1,158 additions and 437 deletions.
41 changes: 40 additions & 1 deletion .all-contributorsrc
Expand Up @@ -521,7 +521,8 @@
"profile": "http://michaelball.co",
"contributions": [
"bug",
"code"
"code",
"test"
]
},
{
Expand Down Expand Up @@ -772,6 +773,35 @@
"name": "Cameron Edwards",
"avatar_url": "https://avatars3.githubusercontent.com/u/5456216?v=4",
"profile": "http://cameronpedwards.com",
"contributions": [
"code",
"test"
]
},
{
"login": "stereobooster",
"name": "stereobooster",
"avatar_url": "https://avatars2.githubusercontent.com/u/179534?v=4",
"profile": "https://github.com/stereobooster",
"contributions": [
"code",
"test"
]
},
{
"login": "1Copenut",
"name": "Trevor Pierce",
"avatar_url": "https://avatars0.githubusercontent.com/u/934879?v=4",
"profile": "https://github.com/1Copenut",
"contributions": [
"review"
]
},
{
"login": "franklixuefei",
"name": "Xuefei Li",
"avatar_url": "https://avatars1.githubusercontent.com/u/1334982?v=4",
"profile": "http://xuefei-frank.com",
"contributions": [
"code"
]
Expand All @@ -784,6 +814,15 @@
"contributions": [
"code"
]
},
{
"login": "dovidweisz",
"name": "D[oa]vid Weisz",
"avatar_url": "https://avatars0.githubusercontent.com/u/6895497?v=4",
"profile": "https://github.com/dovidweisz",
"contributions": [
"code"
]
}
]
}
12 changes: 12 additions & 0 deletions .flowconfig
@@ -0,0 +1,12 @@
[ignore]
.*/node_modules/

[include]
./test

[libs]

[lints]
all=error

[options]
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE.md
Expand Up @@ -11,9 +11,9 @@ never done that before, that's great! Check this free short video tutorial to
learn how: http://kcd.im/pull-request
-->

* `downshift` version:
* `node` version:
* `npm` (or `yarn`) version:
- `downshift` version:
- `node` version:
- `npm` (or `yarn`) version:

Relevant code or config

Expand Down
8 changes: 4 additions & 4 deletions .github/PULL_REQUEST_TEMPLATE.md
Expand Up @@ -34,11 +34,11 @@ merge of your pull request!

<!-- to check an item, place an "x" in the box like so: "- [x] Documentation" -->

* [ ] Documentation
* [ ] Tests
* [ ] Ready to be merged
- [ ] Documentation
- [ ] Tests
- [ ] Ready to be merged
<!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->
* [ ] Added myself to contributors table
- [ ] Added myself to contributors table
<!-- this is optional, see the contributing guidelines for instructions -->

<!-- feel free to add additional comments -->
1 change: 1 addition & 0 deletions .gitignore
Expand Up @@ -16,3 +16,4 @@ cypress/screenshots
# when working with contributors
package-lock.json
yarn.lock
flow-coverage/
32 changes: 16 additions & 16 deletions CODE_OF_CONDUCT.md
Expand Up @@ -6,12 +6,12 @@

**Table of Contents**

* [Our Pledge](#our-pledge)
* [Our Standards](#our-standards)
* [Our Responsibilities](#our-responsibilities)
* [Scope](#scope)
* [Enforcement](#enforcement)
* [Attribution](#attribution)
- [Our Pledge](#our-pledge)
- [Our Standards](#our-standards)
- [Our Responsibilities](#our-responsibilities)
- [Scope](#scope)
- [Enforcement](#enforcement)
- [Attribution](#attribution)

<!-- END doctoc generated TOC please keep comment here to allow auto update -->

Expand All @@ -29,21 +29,21 @@ and orientation.
Examples of behavior that contributes to creating a positive environment
include:

* Using welcoming and inclusive language
* Being respectful of differing viewpoints and experiences
* Gracefully accepting constructive criticism
* Focusing on what is best for the community
* Showing empathy towards other community members
- Using welcoming and inclusive language
- Being respectful of differing viewpoints and experiences
- Gracefully accepting constructive criticism
- Focusing on what is best for the community
- Showing empathy towards other community members

Examples of unacceptable behavior by participants include:

* The use of sexualized language or imagery and unwelcome sexual attention or
- The use of sexualized language or imagery and unwelcome sexual attention or
advances
* Trolling, insulting/derogatory comments, and personal or political attacks
* Public or private harassment
* Publishing others' private information, such as a physical or electronic
- Trolling, insulting/derogatory comments, and personal or political attacks
- Public or private harassment
- Publishing others' private information, such as a physical or electronic
address, without explicit permission
* Other conduct which could reasonably be considered inappropriate in a
- Other conduct which could reasonably be considered inappropriate in a
professional setting

## Our Responsibilities
Expand Down
18 changes: 9 additions & 9 deletions CONTRIBUTING.md
Expand Up @@ -7,9 +7,9 @@ series [How to Contribute to an Open Source Project on GitHub][egghead]

## Project setup

1. Fork and clone the repo
2. `npm run setup` to setup and validate your clone of the project
3. Create a branch for your PR
1. Fork and clone the repo
2. `npm run setup` to setup and validate your clone of the project
3. Create a branch for your PR

> Tip: Keep your `master` branch pointing at the original repository and make
> pull requests from branches on your fork. To do this, run:
Expand Down Expand Up @@ -51,12 +51,12 @@ sure to include those changes (if they exist) in your commit.
There are quite a few test scripts that run as part of a `validate` script in
this project:

* lint - ESLint stuff, pretty basic. Please fix any errors/warnings :)
* build-and-test - This ensures that the built version of `downshift` is what we expect. These tests live in `other/misc-tests/__tests__`.
* test:cover - This is primarily unit tests on the source code and accounts for most of the coverage. We enforce 100% code coverage on this library. These tests live in `src/__tests__`
* test:ts - This runs `tsc` on the codebase to make sure the type script definitions are correct for the `tsx` files in the `test` directory.
* test:ssr - This ensures that downshift works with server-side rendering (it can run and render in an environment without the DOM). These tests live in `other/ssr/__tests__`
* test:cypress - This runs tests in an actual browser. It runs and tests the storybook examples. These tests live in `cypress/integration`.
- lint - ESLint stuff, pretty basic. Please fix any errors/warnings :)
- build-and-test - This ensures that the built version of `downshift` is what we expect. These tests live in `other/misc-tests/__tests__`.
- test:cover - This is primarily unit tests on the source code and accounts for most of the coverage. We enforce 100% code coverage on this library. These tests live in `src/__tests__`
- test:ts - This runs `tsc` on the codebase to make sure the type script definitions are correct for the `tsx` files in the `test` directory.
- test:ssr - This ensures that downshift works with server-side rendering (it can run and render in an environment without the DOM). These tests live in `other/ssr/__tests__`
- test:cypress - This runs tests in an actual browser. It runs and tests the storybook examples. These tests live in `cypress/integration`.

### opt into git hooks

Expand Down

0 comments on commit b003097

Please sign in to comment.