WIP: preact alias, rollup configs + compat-lite #15
Conversation
| @@ -0,0 +1,13 @@ | |||
| export * from 'preact' | |||
| @@ -0,0 +1,11 @@ | |||
| function proptype() {} | |||
| dest: pkg.browser, | ||
| format: 'umd', | ||
| moduleName: pkg.name, | ||
| external: ['dom-scroll-into-view', 'react'], |
There was a problem hiding this comment.
I don't want people to have to install dom-scroll-into-view. I realize it's not exactly small, but I'd rather try to rewrite a smaller version (and contribute back if they'll accept it), or bundle it.
There was a problem hiding this comment.
cool! I do agree - if we can not include it would be better! but I thought it's an external dependency. will take it away and iterate tomorrow.
There was a problem hiding this comment.
I have a small rewrite for scroll-into-view that I can PR :) I ran into the same issue with react-aria.
| @@ -8,6 +8,8 @@ | |||
| "npm": "> 3" | |||
| }, | |||
| "scripts": { | |||
| "build": "rollup -c --environment LIBRARY:react -o dist/index.js", | |||
| "build:preact": "rollup -c --environment LIBRARY:preact -o dist/preact/index.js", | |||
There was a problem hiding this comment.
Could you put these in the package-scripts.js file as part of the build script, and add them to the validate script?
If you're unfamiliar with nps that's fine, I can merge this and fix that up myself later :)
There was a problem hiding this comment.
oh crap! I oversaw that, yeah that's easy I can do it..
There was a problem hiding this comment.
Would be best if we could make the build.default be concurrent.nps('build.react', 'build.preact') or something 馃憤
|
Alrighty! I've created a build and added preact support!! 馃帀 Thank you @zouhir! I used this as an example for a bunch of stuff. Much appreciated 馃槃 |
* Fix ESC key in examples Pressing the ESC key clears the input and calls onChange with null. Some examples did not handle this case and crash as a result. downshift-js#719 Update debounce-fn to fix gmail and axios examples * Set debounce-fn to ^3.0.1
馃毇 Not ready for merge.
I've only sent a PR from my private fork for reviews and opinions.
Having a little issue with #4 when I rollup using the configs below, only reason I've posted here is I have not fiddled much recently with React tools and specs in depth. I'll be investigating that..
dom-scroll-into-viewnumber, obj, any