Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(prettier): ignore package.json #255

Merged
merged 1 commit into from
Nov 8, 2017
Merged

chore(prettier): ignore package.json #255

merged 1 commit into from
Nov 8, 2017

Conversation

wKovacs64
Copy link
Contributor

What:

Ignore package.json when formatting with prettier to avoid conflicting with the npm/yarn format.

Why:

npm and yarn both format package.json in a common, opinionated way. Formatting JSON files with prettier yields a different result. People using the popular editor.formatOnSave feature in VSCode with prettier integration (for example) will inadvertently reformat package.json and clutter up commits going back and forth between the two formats any time npm or yarn modifies package.json. Other forms of automated formatting will also reveal the problem (even npm run setup as documented in this project's contributing guide). It looks like package.json was most likely formatted with prettier in 1b1fd1b.

How:

  • added package.json to .prettierignore
  • reformatted package.json to prevent future diffs

Checklist:

  • Documentation N/A
  • Tests N/A
  • Ready to be merged
  • Added myself to contributors table

See also:
Stop re-formatting package.json with Prettier and VSCode once and for all by Martin Hochel

@codecov-io
Copy link

Codecov Report

Merging #255 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #255   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         296    296           
  Branches       71     71           
=====================================
  Hits          296    296

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42a142c...282e4c7. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine with me 👍 Thanks!

@kentcdodds kentcdodds merged commit b04cc25 into downshift-js:master Nov 8, 2017
@wKovacs64 wKovacs64 deleted the wKovacs64/patch-1 branch November 8, 2017 21:58
Rendez pushed a commit to Rendez/downshift that referenced this pull request Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants