New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aria): improve WAI-ARIA compliance #396
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,22 +5,21 @@ exports[`renders with React Native components 1`] = ` | |
aria-expanded={false} | ||
aria-haspopup="listbox" | ||
aria-labelledby="downshift-0-label" | ||
aria-owns="downshift-0-menu" | ||
aria-owns={null} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't worry about this. This is react-native and it's actually just the value of the props. When it's rendered the prop wont actually be there at all. |
||
role="combobox" | ||
> | ||
<TextInput | ||
allowFontScaling={true} | ||
aria-activedescendant={null} | ||
aria-autocomplete="list" | ||
aria-controls="downshift-0-menu" | ||
aria-controls={null} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same story here. |
||
aria-expanded={false} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @kentcdodds I'm sorry, I missed this one on first go-round. The There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Perfect! Thanks! I'll just push that directly to the |
||
aria-labelledby="downshift-0-label" | ||
autoComplete="off" | ||
id="downshift-0-input" | ||
onBlur={[Function]} | ||
onChangeText={[Function]} | ||
onKeyDown={[Function]} | ||
role="listbox" | ||
value="" | ||
/> | ||
<View> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's what this looks like (scroll down): https://github.com/paypal/downshift/blob/7f66c4e143a9e0b5155d973469d3c1f953be4f87/README.md
You ok with this @1Copenut? Just want to make sure we give you the proper accolades for your contributions :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kentcdodds Yes, this is great. I added one more comment about an attribute I missed on the first pass, but everything else looks 馃挴.