Correction on blur event handler on iOS #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 28, 2017 01:31
- Removing onBlur handler and reset function
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
- Coverage 18.55% 18.34% -0.21%
==========================================
Files 8 8
Lines 221 218 -3
Branches 46 45 -1
==========================================
- Hits 41 40 -1
+ Misses 140 139 -1
+ Partials 40 39 -1
Continue to review full report at Codecov.
|
Closed
dashed
reviewed
Jul 28, 2017
| this.autocomplete.reset() | ||
| } | ||
| } | ||
|
|
||
| reset = () => { | ||
| moveCursorToTheEnd(this._inputNode) |
There was a problem hiding this comment.
@psicotropicos I think this was also supposed to be removed.
I tried this PR in a project and was unable to unfocus in Safari.
There was a problem hiding this comment.
Hah, yeah, maybe we should remove this call (and the method itself from utils because it's not used elsewhere).
Would you like to make that change @dashed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing onBlur handler and reset function