Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DownThemAll removes filename from downloads started by another extension #246

Open
ghost opened this issue May 25, 2020 · 6 comments
Open
Labels
bug Something isn't working P4 Priorty 4 (infeasible/impossible)

Comments

@ghost
Copy link

ghost commented May 25, 2020

Desktop (please complete the following information):

  • OS: Linux Ubuntu, Kubuntu
  • Browser and version: Chrome 83.0.4103.61 (Official Build) (64-bit)
  • DownThemAll! version: 4.2.6

Describe the bug
imgding (another Browser-Extension) starts a download with a filename:

let download = {
            url: http://example.com/1234.jpg,
            filename: 'foo/bar.jpg'
        };
        browser.downloads.download(download)....

The filename gets lost, if DownThemAll is installed. With DownThemAll installed the filename is taken from the URL ('1234.jpg') and the file goes into the default download folder.
Without DownThemAll installed, the file is downloaded to 'foo/bar.jpg' in the default download folder, with 'foo' being a sub-folder

I suspect that DownThemAll intercepts the download and ignores or removes the supplied the file name.

@ghost ghost changed the title DownThemAll removes filename from downlaods started by another extension DownThemAll removes filename from downloads started by another extension May 25, 2020
@ghost
Copy link
Author

ghost commented May 27, 2020

I created a small extension that adds a context menu and downloads a file. Just unzip it and and "Load Unpacked" into Chrome or Chromium. It seems that Firefox is not affected.

If DownThemAll is installed, the file is downloaded as 'Readme.md' into the default download folder.
If DownThemAll is not installed, the file is downloaded to 'foo/My-Readme.md' as specified in the download request.

const init = () => {
    chrome.contextMenus.create({
        id: 'download-test',
        title: 'download-test',
        contexts: ['page']
    });
    chrome.contextMenus.onClicked.addListener((info, tab) => {
        if (info.menuItemId === 'download-test') {
            chrome.downloads.download({
                url: 'https://raw.githubusercontent.com/downthemall/downthemall/master/Readme.md',
                filename: 'foo/My-Readme.md'
            })

        }
    })
}

downloadtest.zip

@Bamajon1974
Copy link

Bamajon1974 commented Jul 17, 2020

I downloaded the download test extension, with Downthemall installed, loaded the extension unpacked, right clicked on a web page and the extension downloaded readme.me into the download folder.

What do I do now?

@ghost
Copy link
Author

ghost commented Jul 17, 2020

I downloaded the download test extension, with Downthemall installed, loaded the extension unpacked, right clicked on a web page and the extension downloaded readme.me into the download folder.

What do I do now?

Sorry, I think there is a misunderstanding. This test extension does not solve the problem. It is intended to easily reproduce the problem.
I linked this issues because I think they have the same root cause.

@Bamajon1974
Copy link

Got it. Please alert users when the issue is fixed.

Thanks!

@Rob--W
Copy link

Rob--W commented Aug 14, 2020

This is an issue with Chrome:

@nmaier nmaier added bug Something isn't working P4 Priorty 4 (infeasible/impossible) labels Aug 29, 2020
@adamwinn
Copy link

adamwinn commented Jan 4, 2021

I'm seeing this with the Online Download Manager extension too

This extension failed to name the download "" because another extension (DownThemAll!) determined a different filename

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P4 Priorty 4 (infeasible/impossible)
Projects
None yet
Development

No branches or pull requests

4 participants