Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix requestError and timeout bug #7

Merged
merged 3 commits into from
Sep 6, 2017
Merged

Conversation

doxiaodong
Copy link
Owner

it shouldn't goto timeout after fetch api finish

it shouldn't goto requestError/response after timeout

it shouldn't goto timeout after fetch api finish

it shouldn't goto requestError/response after timeout
@doxiaodong
Copy link
Owner Author

@9173860

@codecov-io
Copy link

codecov-io commented Sep 5, 2017

Codecov Report

Merging #7 into master will increase coverage by 0.48%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   75.35%   75.83%   +0.48%     
==========================================
  Files           4        4              
  Lines         142      149       +7     
  Branches       19       19              
==========================================
+ Hits          107      113       +6     
- Misses         35       36       +1
Impacted Files Coverage Δ
src/fetch.ts 78.72% <91.66%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 097dfee...5658d2a. Read the comment docs.

@doxiaodong doxiaodong merged commit 6d79a27 into master Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants