Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup CI and Gem Publishing + better form validation #10

Merged
merged 20 commits into from
Feb 12, 2021
Merged

Conversation

Austio
Copy link
Contributor

@Austio Austio commented Feb 8, 2021

This PR Sets up CI to allow

  • running standardrb
  • running tests
  • Gem Publishing

2 other changes in here

  • Validate the form for things that we know will not work (like spaces in rake arguments)
  • Respect form input values whenever we have a "back" event for filtering

@Austio Austio marked this pull request as ready for review February 11, 2021 15:02
@Austio Austio changed the title Add CI file for running specs automatically Setup CI and Gem Publishing Feb 11, 2021
@Austio Austio changed the title Setup CI and Gem Publishing Setup CI and Gem Publishing + better form validation Feb 11, 2021
…ic internal test when asserting values of those tests
@Austio Austio force-pushed the setup-ci branch 2 times, most recently from dbb9635 to a9e3070 Compare February 12, 2021 21:55
@Austio Austio merged commit 27dea30 into master Feb 12, 2021
@Austio Austio deleted the setup-ci branch February 12, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants