Skip to content

Commit

Permalink
Wrong link generated for inherited members when tag files are used.
Browse files Browse the repository at this point in the history
In case a tag file is used and `EXT_LINKS_IN_WINDOW` is set to `YES` a link is generated of the form:
`Public Member Functions inherited from <a class="el" href="target="_blank" https://doc.qt.io/archives/qt-5.10/qobject.html">`
instead of
`Public Member Functions inherited from <a class="el" target="_blank" href="https://doc.qt.io/archives/qt-5.10/qobject.html">`

When `EXT_LINKS_IN_WINDOW` is set to `NO` a correct link is generated but the external documentation comes straight forward in the current window.

(relevant link: https://stackoverflow.com/questions/51323207/doxygen-external-link-to-qt-classes)
  • Loading branch information
albert-github committed Jul 13, 2018
1 parent e8df803 commit 135412e
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions src/htmlgen.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2717,13 +2717,16 @@ void HtmlGenerator::writeInheritedSectionTitle(
DBG_HTML(t << "<!-- writeInheritedSectionTitle -->" << endl;)
QCString a = anchor;
if (!a.isEmpty()) a.prepend("#");
QCString classLink = QCString("<a class=\"el\" href=\"");
QCString classLink = QCString("<a class=\"el\" ");
if (ref)
{
classLink+= externalLinkTarget() + externalRef(relPath,ref,TRUE);
classLink+= externalLinkTarget();
classLink += " href=\"";
classLink+= externalRef(relPath,ref,TRUE);
}
else
{
classLink += "href=\"";
classLink+=relPath;
}
classLink+=file+Doxygen::htmlFileExtension+a;
Expand Down

0 comments on commit 135412e

Please sign in to comment.