Skip to content

Commit

Permalink
Coverity uninitialized
Browse files Browse the repository at this point in the history 
Fixing a number of uninitialized variables based on the coverity output of November 30, 2019
  • Loading branch information
@albert-github
albert-github committed Dec 2, 2019
1 parent 9b14bf5 commit ef06c8d
Show file tree
Hide file tree
Showing 21 changed files with 352 additions and 352 deletions.
10 changes: 5 additions & 5 deletions addon/doxmlparser/src/basehandler.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ template<class T> class ElementMapper
void operator()(const QXmlAttributes &attrib)
{ if (m_parent) (m_parent->*m_handler)(attrib); }
private:
T *m_parent;
T *m_parent = 0;
Handler m_handler;
};

Expand All @@ -71,7 +71,7 @@ template<class T> class ElementMapper
void operator()()
{ if (m_parent) (m_parent->*m_handler)(); }
private:
T *m_parent;
T *m_parent = 0;
Handler m_handler;
};

Expand Down Expand Up @@ -277,9 +277,9 @@ template<class T> class BaseHandler : public QXmlDefaultHandler,
protected:
QString m_curString;
QString m_skipUntil;
int m_skipCount;
QXmlDefaultHandler *m_delegateHandler;
IFallBackHandler *m_fallBackHandler;
int m_skipCount = 0;
QXmlDefaultHandler *m_delegateHandler = 0;
IFallBackHandler *m_fallBackHandler = 0;
};

//-----------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion addon/doxmlparser/src/compoundhandler.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ class CompoundIdIterator : public ICompoundIterator,
{ delete this; }

private:
const MainHandler *m_mainHandler;
const MainHandler *m_mainHandler = 0;
};

//----------------------------------------------------------------------------
Expand Down
40 changes: 20 additions & 20 deletions addon/doxmlparser/src/compoundhandler.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,10 @@ class IncludeHandler : public IInclude, public BaseHandler<IncludeHandler>
{ return m_isLocal; }

private:
IBaseHandler *m_parent;
IBaseHandler *m_parent = 0;
StringImpl m_name; // element's content
StringImpl m_refId; // refid
bool m_isLocal; // local
bool m_isLocal = false; // local
};

class IncludeIterator : public BaseIterator<IIncludeIterator,IInclude,IncludeHandler>
Expand Down Expand Up @@ -86,10 +86,10 @@ class RelatedCompound : public IRelatedCompound
virtual const IString *name() const { return &m_name; }

private:
CompoundHandler *m_parent;
CompoundHandler *m_parent = 0;
QString m_id; // refid
Protection m_protection; // prot
Kind m_kind; // virt
Protection m_protection = Public; // prot
Kind m_kind = Normal; // virt
StringImpl m_name; // element's content
};

Expand Down Expand Up @@ -193,42 +193,42 @@ class CompoundHandler : public IClass,
// XML elements:
// -------------
StringImpl m_name; // compoundname
TitleHandler* m_titleHandler; // title
TitleHandler* m_titleHandler = 0; // title
QList<RelatedCompound> m_subClasses; // basecompoundref
QList<RelatedCompound> m_superClasses; // derivedcompoundref
QList<IncludeHandler> m_includes; // includes
QList<IncludeHandler> m_includedBy; // includedBy
GraphHandler* m_includeDependencyGraph; // incdepgraph
GraphHandler* m_includedByDependencyGraph; // invincdepgraph
GraphHandler* m_includeDependencyGraph = 0;// incdepgraph
GraphHandler* m_includedByDependencyGraph = 0; // invincdepgraph
QList<QString> m_innerCompounds; // innerdir/innerfile/innerclass/innernamespace/innergroup
TemplateParamListHandler* m_templateParamList; // templateparamlist
QList<SectionHandler> m_sections; // sectiondef
DocHandler* m_brief; // briefdescription
DocHandler* m_detailed; // detaileddescription
GraphHandler* m_inheritanceGraph; // inheritancegraph
GraphHandler* m_collaborationGraph; // collaborationgraph
ProgramListingHandler* m_programListing; // programlisting
DocHandler* m_brief = 0; // briefdescription
DocHandler* m_detailed = 0; // detaileddescription
GraphHandler* m_inheritanceGraph = 0; // inheritancegraph
GraphHandler* m_collaborationGraph = 0; // collaborationgraph
ProgramListingHandler* m_programListing = 0; // programlisting
// location
StringImpl m_defFile; // - file
int m_defLine; // - line
int m_defLine = 0; // - line
StringImpl m_defBodyFile; // - bodyfile
int m_defBodyStart; // - bodystart
int m_defBodyEnd; // - bodyend
ListOfAllMembersHandler* m_members; // listofallmember
int m_defBodyStart = 0; // - bodystart
int m_defBodyEnd = 0; // - bodyend
ListOfAllMembersHandler* m_members = 0; // listofallmember

// XML attributes:
// ---------------
StringImpl m_id; // id
CompoundKind m_kind; // kind
CompoundKind m_kind = Invalid; // kind
StringImpl m_kindString; // kind as a string
StringImpl m_protection; // prot

// local variables
QString m_xmlDir; // directory where the info is found
int m_refCount; // object reference counter
int m_refCount = 0; // object reference counter
QDict<MemberHandler> m_memberDict; // id->member lookup
QDict<QList<MemberHandler> > m_memberNameDict; // name->memberlist lookup
MainHandler* m_mainHandler; // parent object
MainHandler* m_mainHandler = 0; // parent object
};

void compoundhandler_init();
Expand Down
2 changes: 1 addition & 1 deletion addon/doxmlparser/src/linkedtexthandler.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class LT_Ref : public LinkedTextImpl, public ILT_Ref
StringImpl m_refId;
StringImpl m_extId;
StringImpl m_text;
TargetKind m_targetKind;
TargetKind m_targetKind = TargetKind::Member;
};

LinkedTextHandler::LinkedTextHandler(IBaseHandler *parent,
Expand Down
114 changes: 57 additions & 57 deletions addon/doxywizard/wizard.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,11 @@ class TuneColorDialog : public QDialog
void updateImage(int hue,int sat,int val);

private:
QImage *m_image;
QLabel *m_imageLab;
int m_hue;
int m_sat;
int m_gam;
QImage *m_image = 0;
QLabel *m_imageLab = 0;
int m_hue = 0;
int m_sat = 0;
int m_gam = 0;
};

class ColorPicker : public QWidget
Expand Down Expand Up @@ -89,11 +89,11 @@ public slots:
void setSat(int v);
void setGam(int v);

QPixmap *m_pix;
Mode m_mode;
int m_gam;
int m_hue;
int m_sat;
QPixmap *m_pix = 0;
Mode m_mode = Hue;
int m_gam = 0;
int m_hue = 0;
int m_sat = 0;

};

Expand All @@ -118,16 +118,16 @@ class Step1 : public QWidget
void setRecursiveScan(int);

private:
QLineEdit *m_projName;
QLineEdit *m_projBrief;
QLineEdit *m_projNumber;
QLineEdit *m_sourceDir;
QLineEdit *m_destDir;
QLabel *m_projIconLab;
QCheckBox *m_recursive;
QPushButton *m_srcSelectDir;
QPushButton *m_dstSelectDir;
Wizard *m_wizard;
QLineEdit *m_projName = 0;
QLineEdit *m_projBrief = 0;
QLineEdit *m_projNumber = 0;
QLineEdit *m_sourceDir = 0;
QLineEdit *m_destDir = 0;
QLabel *m_projIconLab = 0;
QCheckBox *m_recursive = 0;
QPushButton *m_srcSelectDir = 0;
QPushButton *m_dstSelectDir = 0;
Wizard *m_wizard = 0;
const QHash<QString,Input *> &m_modelData;
};

Expand All @@ -144,12 +144,12 @@ class Step2 : public QWidget
void changeCrossRefState(int choice);

private:
QGroupBox *m_extractMode;
QGroupBox *m_optimizeLang;
QButtonGroup *m_extractModeGroup;
QButtonGroup *m_optimizeLangGroup;
QCheckBox *m_crossRef;
Wizard *m_wizard;
QGroupBox *m_extractMode = 0;
QGroupBox *m_optimizeLang = 0;
QButtonGroup *m_extractModeGroup = 0;
QButtonGroup *m_optimizeLangGroup = 0;
QCheckBox *m_crossRef = 0;
Wizard *m_wizard = 0;
const QHash<QString,Input *> &m_modelData;
};

Expand All @@ -173,18 +173,18 @@ class Step3 : public QWidget
void tuneColorDialog();

private:
QGroupBox *m_texOptions;
QButtonGroup *m_texOptionsGroup;
QGroupBox *m_htmlOptions;
QButtonGroup *m_htmlOptionsGroup;
QCheckBox *m_htmlEnabled;
QCheckBox *m_latexEnabled;
QCheckBox *m_manEnabled;
QCheckBox *m_rtfEnabled;
QCheckBox *m_xmlEnabled;
QCheckBox *m_searchEnabled;
QPushButton *m_tuneColor;
Wizard *m_wizard;
QGroupBox *m_texOptions = 0;
QButtonGroup *m_texOptionsGroup = 0;
QGroupBox *m_htmlOptions = 0;
QButtonGroup *m_htmlOptionsGroup = 0;
QCheckBox *m_htmlEnabled = 0;
QCheckBox *m_latexEnabled = 0;
QCheckBox *m_manEnabled = 0;
QCheckBox *m_rtfEnabled = 0;
QCheckBox *m_xmlEnabled = 0;
QCheckBox *m_searchEnabled = 0;
QPushButton *m_tuneColor = 0;
Wizard *m_wizard = 0;
const QHash<QString,Input *> &m_modelData;
};

Expand All @@ -207,17 +207,17 @@ class Step4 : public QWidget
void setCallerGraphEnabled(int state);

private:
QGroupBox *m_diagramMode;
QButtonGroup *m_diagramModeGroup;
QGroupBox *m_dotGroup;
QCheckBox *m_dotClass;
QCheckBox *m_dotCollaboration;
QCheckBox *m_dotInclude;
QCheckBox *m_dotIncludedBy;
QCheckBox *m_dotInheritance;
QCheckBox *m_dotCall;
QCheckBox *m_dotCaller;
Wizard *m_wizard;
QGroupBox *m_diagramMode = 0;
QButtonGroup *m_diagramModeGroup = 0;
QGroupBox *m_dotGroup = 0;
QCheckBox *m_dotClass = 0;
QCheckBox *m_dotCollaboration = 0;
QCheckBox *m_dotInclude = 0;
QCheckBox *m_dotIncludedBy = 0;
QCheckBox *m_dotInheritance = 0;
QCheckBox *m_dotCall = 0;
QCheckBox *m_dotCaller = 0;
Wizard *m_wizard = 0;
const QHash<QString,Input *> &m_modelData;
};

Expand All @@ -241,14 +241,14 @@ class Wizard : public QSplitter

private:
const QHash<QString,Input *> &m_modelData;
QTreeWidget *m_treeWidget;
QStackedWidget *m_topicStack;
Step1 *m_step1;
Step2 *m_step2;
Step3 *m_step3;
Step4 *m_step4;
QPushButton *m_next;
QPushButton *m_prev;
QTreeWidget *m_treeWidget = 0;
QStackedWidget *m_topicStack = 0;
Step1 *m_step1 = 0;
Step2 *m_step2 = 0;
Step3 *m_step3 = 0;
Step4 *m_step4 = 0;
QPushButton *m_next = 0;
QPushButton *m_prev = 0;
};

#endif
Loading

0 comments on commit ef06c8d

Please sign in to comment.