Skip to content

Commit

Permalink
Consistency not generated inheritance diagram
Browse files Browse the repository at this point in the history
Also warn when an inheritance diagram is not generated.
Corrected "dead" code in if statement
  • Loading branch information
albert-github committed Jun 7, 2019
1 parent e773e6c commit ef859cb
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 5 additions & 1 deletion src/classdef.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1718,7 +1718,11 @@ void ClassDefImpl::writeInheritanceGraph(OutputList &ol) const
// write class diagram using dot
{
DotClassGraph inheritanceGraph(this,DotNode::Inheritance);
if (!inheritanceGraph.isTrivial() && !inheritanceGraph.isTooBig())
if (inheritanceGraph.isTooBig())
{
warn_uncond("Inheritance graph for '%s' not generated, too many nodes. Consider increasing DOT_GRAPH_MAX_NODES.\n",name().data());
}
else if (!inheritanceGraph.isTrivial())
{
ol.pushGeneratorState();
ol.disable(OutputGenerator::Man);
Expand Down
2 changes: 1 addition & 1 deletion src/memberdef.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2945,7 +2945,7 @@ void MemberDefImpl::_writeCallerGraph(OutputList &ol) const
{
warn_uncond("Caller graph for '%s' not generated, too many nodes. Consider increasing DOT_GRAPH_MAX_NODES.\n",qPrint(qualifiedName()));
}
else if (!callerGraph.isTrivial() && !callerGraph.isTooBig())
else if (!callerGraph.isTrivial())
{
msg("Generating caller graph for function %s\n",qPrint(qualifiedName()));
ol.disable(OutputGenerator::Man);
Expand Down

0 comments on commit ef859cb

Please sign in to comment.