Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search_opensearch.php wrongly indicates that each suggestion has exactly 1 result #10017

Closed
Krinkle opened this issue Apr 30, 2023 · 3 comments
Closed

search_opensearch.php wrongly indicates that each suggestion has exactly 1 result #10017

Krinkle opened this issue Apr 30, 2023 · 3 comments
Labels
bug HTML HTML / XHTML output

Comments

@Krinkle
Copy link
Contributor

Krinkle commented Apr 30, 2023

Describe the bug (Actual behaviour):

https://doc.wikimedia.org/mediawiki-core/master/php/search_opensearch.php?v=json

["foo", ["footer", "footers", "footerhtml", …, "fooey"],["1 result", "1 result", "1 result", … "1 result"]]

There is also a warning in the server-side PHP error.log:

PHP Warning:  array_key_exists(): The first argument should be either a string or an integer)

Expected behavior

["foo", ["footer", "footers", "footerhtml", …, "fooey"],["33 results", "4 results", "5 results", … "1 result"]]

Version
1.9.6
Krinkle added a commit to Krinkle/doxygen that referenced this issue Apr 30, 2023
@Krinkle
search: Fix incorrect result count in opensearch suggestions
e823202 
The descriptions displayed under the OpenSearch suggestions
in a web browser always said "1 result". This also emitted
a warning on the server-side:

> PHP Warning:  array_key_exists(): The first argument should be
> either a string or an integer)

Fixes doxygen#10017.
@Krinkle Krinkle mentioned this issue Apr 30, 2023
Merged
@albert-github
Copy link
Collaborator

Please don't add a link to a pull request that closes the issue.
When merged doxygen will close the issue at the next release after the merge.

Krinkle added a commit to Krinkle/doxygen that referenced this issue Apr 30, 2023
@Krinkle
search: Fix incorrect result count in opensearch suggestions
6332782 
The descriptions displayed under the OpenSearch suggestions
in a web browser always said "1 result". This also emitted
a warning on the server-side:

> PHP Warning:  array_key_exists(): The first argument should be
> either a string or an integer)

Ref doxygen#10017.
@Krinkle
Copy link
Contributor Author

Krinkle commented Apr 30, 2023 •
edited

@albert-github Okay, I've updated the commit message to say "Ref" instead of "Fixes" to avoid automatic closure.

@doxygen doxygen added the fixed but not released Bug is fixed in github, but still needs to make its way to an official release label May 6, 2023
@doxygen
Copy link
Owner

doxygen commented May 18, 2023

This issue was previously marked 'fixed but not released',
which means it should be fixed in doxygen version 1.9.7.
Please verify if this is indeed the case. Reopen the
issue if you think it is not fixed and please include any additional information
that you think can be relevant (preferably in the form of a self-contained example).

@doxygen doxygen removed the fixed but not released Bug is fixed in github, but still needs to make its way to an official release label May 18, 2023
@doxygen doxygen closed this as completed May 18, 2023
@albert-github albert-github added bug HTML HTML / XHTML output labels Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug HTML HTML / XHTML output
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Krinkle @doxygen @albert-github