New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make polyfill optional, at least. #10354
Comments
I'm happy to provide a PR, ideally just removing the relevant line. Lmk whether that's desirable. |
IE11 might look like to be dead but
Seen this I don't think it is possible yet to remove this line completely, a possibility might be to have (in the resulting HTML file a construct that detects whether or not IE11 is used and when that is the case the part
is enabled. |
Thanks a lot, @albert-github ! The problem I'm trying to solve is that we want our Doxygen doc (which uses MathJax) to be GDPR compliant. For that we must not pull in polyfill, not even if someone uses IE11. Your comment suggests that this would need to become a configuration option? Maybe as
All of this is obviously really your call, I'm just suggesting possible approaches hoping that you would agree that GDPR compliance is good to offer, and that you'd tell me how I can contribute to make it happen! |
I don't think the polyfill can be removed for IE11 seen the comment you cited from MathJax. |
I understood your suggestion - apologies for not making that clear. But this means that polyfill will be loaded, even if only in certain cases, and thus websites using Doxygen documentation will not be GDPR compliant. |
When I understand it well the |
Well, GDPR basically says (INAL) that you cannot use US-based services. polyfill is US based. MathJax works well without polyfill (except IE11). So not sure what to report to either polyfill or MathJax here... It's doxygen that unconditionally pulls in polyfill if MathJax3 is on, and that's what I need to fix. |
According to this site the worldwide use of IE has dropped to 0.22%. Of those users only a small subset will be using it for doxygen pages, and an even smaller subset will be using Mathjax, so I don't mind to remove the polyfill dependency, and wait for the unlikely bug report that someone finds this a problem. |
It doesn't look like much users, but it always depends on what one is measuring, when measuring social networks the results will be different from technical networks. Also there are companies that still use systems that are not (directly) connected to the internet and that run old versions of OS. The later will not likely be using the newest versions of doxygen or update to it so the risk would be small. Maybe the suggested |
No-network doesn't seem like a scenario where loading polyfill.io would work anyway? |
Indeed. |
I've removed the reference to polyfill. If someone still needs it do the following:
Edit
|
This issue was previously marked 'fixed but not released', |
Describe the bug
Requesting mathJax unconditionally pulls in polyfill.io. GDPR-wise that's a problem, at least for us. Also, Browser Support for ES6 (2015) suggests that this should really not be an issue anymore.
If really need be this could become configurable.
Expected behavior
I can use doxygen-generated documentation (including MathJax) without connecting other servers.
To Reproduce
See e.g. the network trace of https://root.cern/doc/v628/
Version
That's probably not really relevant here - but we use doxygen from Ubuntu 22.04.
Additional context
On this topic, MathJax says
IE11 is dead, please :-)
The text was updated successfully, but these errors were encountered: