Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit C# event mistaken for property #10799

Open
ni-gergokozma opened this issue Apr 15, 2024 · 3 comments
Open

Explicit C# event mistaken for property #10799

ni-gergokozma opened this issue Apr 15, 2024 · 3 comments
Labels
bug C# fixed but not released Bug is fixed in github, but still needs to make its way to an official release

Comments

@ni-gergokozma
Copy link

ni-gergokozma commented Apr 15, 2024

Describe the bug

Hello Doxygen team!

We accidentally ran into a minor bug with events in C#. Take a look at the following interface:

image

We expected to both of these events show up in events section in the XML output. However, the XML output looks like this:

image

As shown above the event without an explicit body (OnEventExtracted) shows up in the correct section. However, the one with an explicit body (OnEventNotExtracted), is considered a property. Which is not the case; it's just an explicit declaration of the add and remove operations (+= and -=) for the event.

To Reproduce

Run doxygen on the attached example:
bug_repro.zip

Expected behavior
Events defined with explicit bodies should be treated as events and not as properties in the XML output.

Version
We are using Doxygen version 1.9.6, but we were able to reproduce this with the latest 1.10.0 version as well.

albert-github added a commit to albert-github/doxygen that referenced this issue Apr 15, 2024
In case of C# it is possible that the word `event` is filtered out already and that was not considered  yet.
@albert-github
Copy link
Collaborator

I've just pushed a proposed patch, pull request #10800

(The issue was also visible with other output formats)

doxygen added a commit that referenced this issue Apr 15, 2024
issue #10799 Explicit C# event mistaken for property
@albert-github albert-github added the fixed but not released Bug is fixed in github, but still needs to make its way to an official release label Apr 16, 2024
@albert-github
Copy link
Collaborator

Code has been integrated in master on GitHub (please don't close the issue as this will be done at the moment of an official release).

@ni-gergokozma
Copy link
Author

Thank you! That was super quick! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug C# fixed but not released Bug is fixed in github, but still needs to make its way to an official release
Projects
None yet
Development

No branches or pull requests

2 participants