-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More restrictive block-id character set in Doxygen >= 1.10 #10859
Comments
In the doxygen 1.9.8 version we see that the relevant code (in this case it is still in doctokenizer.l) is:
in other words every character except a line ending was allowed. |
…n >= 1.10 Corrected block-id usage for `\snippet{doc}` conform "old" usage and usage with other `\snippet` commands (the later see doctokenizer.l).
I've just pushed a proposed patch, pull request #10862 |
issue #10859 More restrictive block-id character set in Doxygen >= 1.10
Code has been integrated in master on GitHub (please don't close the issue as this will be done at the moment of an official release). |
This issue was previously marked 'fixed but not released', |
Describe the bug
Doxygen 1.9 supported
With Doxygen 1.10 the
-baz
portion is ignored and the snippet cannot be found.To Reproduce
doxygen-repro.tar.gz
Extract the tarball and run:
The Dockerfile may be convenient if you don't have Doxygen 1.9 and 1.10
available. Fedora:39 ships with Doxygen 1.9, and this passes:
while this fails:
Expected behavior
I expected the repro to succeed with Doxygen >= 1.10.
Version
Additional context
I think the change in behavior was introduced as part of:
7780d51
Specifically this:
doxygen/src/commentcnv.l
Line 225 in 3ce42bf
The regular expression for
ID
does not accept spaces, or dashes, or a number of other characters. If this is intentional, documenting the accepted character set would be useful.The text was updated successfully, but these errors were encountered: