Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misparsed comments leading to missing call graph (Origin: bugzilla #727103) #5442

Closed
doxygen opened this issue Jul 2, 2018 · 1 comment
Closed

Comments

@doxygen
Copy link
Owner

doxygen commented Jul 2, 2018

status ASSIGNED severity normal in component general for ---
Reported in version 1.8.6 on platform Other
Assigned to: Dimitri van Heesch

On 2014-03-26 17:13:11 +0000, Daniel Sheridan wrote:

I found a function missing from a call graph in a large third-party code
base. I've traced the issue to an oddly formatted comment to produce this
minimal example:

/*///*/

void c() {
  c();
}

void main() {
  c();
}

With the three slashes in the comment, no callgraph is generated for c() or
main(). With two slashes (i.e., /*//*/), the callgraphs are generated as
expected.

The following also fails: /* random text ///*/

While this succeeds: /*/// */

On 2014-03-26 17:13:42 +0000, Daniel Sheridan wrote:

I should add that this is C++.

On 2018-05-12 17:02:12 +0000, albert wrote:

In the current version (1.8.14) we get the warning:
  aa.cpp:14: warning: Reached end of file while still inside a (nested)
comment. Nesting level 2 (probable line reference: 3, 3)

(I added 2 lines at the beginning of the file.)

In version 1.8.6 this message is not given.

In the string we see the start of the nested comment:
/*///*/
    ^ start of the nested comment.

It strongly advised to fix this warning (also upstream in the third-party
software / inform that party about it).

When we look at the code coloring (SOURCE_BROWSER = YES,
STRIP_CODE_COMMENTS=NO we see also that the functions are in the comment
color)


I've just pushed a proposed patch to github (pull request 721,
https://github.com/doxygen/doxygen/pull/721).

On 2018-06-27 10:33:39 +0000, albert wrote:

2018/06/24 Code has been integrated in master on github.
@doxygen doxygen added the fixed but not released Bug is fixed in github, but still needs to make its way to an official release label Jul 18, 2018
@doxygen
Copy link
Owner Author

doxygen commented Aug 8, 2019

This issue was previously marked 'fixed but not released',
which means it should be fixed in doxygen version 1.8.16.
Please verify if this is indeed the case. Reopen the
issue if you think it is not fixed and please include any additional information
that you think can be relevant (preferably in the form of a self-contained example).

@doxygen doxygen removed the fixed but not released Bug is fixed in github, but still needs to make its way to an official release label Aug 8, 2019
@doxygen doxygen closed this as completed Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant