Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reserved identifier violation #7195

Closed
elfring opened this issue Aug 14, 2019 · 6 comments
Closed

reserved identifier violation #7195

elfring opened this issue Aug 14, 2019 · 6 comments
Labels
install/build bug in the installation or build scripts

Comments

@elfring
Copy link

elfring commented Aug 14, 2019

I would like to point out that identifiers like “_DOCHANDLER_H” and “_SEARCHINDEX_H” do not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?
backwardn pushed a commit to backwardn/doxygen that referenced this issue Aug 18, 2019
@albert-github
issue doxygen#7190 1.8.16: Blank FILE_PATTERNS => no files processed
a27369d 
This is actually a regression on doxygen#7195. Due to the fact that the init() routine has moved up, the settings for `FILE_PATTERNS` have already been done and a call to init does not operate on the `FILE_PATTERNS` variable but on the structure from which the `FILE_PATTERNS` was derived. We have should here operate on the `FILE_PATTERNS` directly as well., bu getting the default values out of the underlying structure.
@albert-github albert-github added install/build bug in the installation or build scripts solved in the mean time Bug solved in a previous version, to be confirmed labels Jul 11, 2021
@albert-github
Copy link
Collaborator

The doxmlparser has been rewritten (from a C++ implementation to a puthon implementation), so the file dochandler.h does not exist anymore.
The guard in searchindex.h has been renamed from _SEARCHINDEX_H to the compliant name SEARCHINDEX_H.

I think the problem has been solved in the mean time

@elfring
Copy link
Author

elfring commented Jul 12, 2021

Thanks for an adjustment of an affected include guard.

Were any update candidates left over?

@albert-github albert-github removed the solved in the mean time Bug solved in a previous version, to be confirmed label Jul 12, 2021
@albert-github
Copy link
Collaborator

Later I realized that there are a few other places as well (one indicated by the little bit cryptic "Were any update candidates left over?"), will look into this later. With the issue I only looked into the mentioned problems.

albert-github added a commit to albert-github/doxygen that referenced this issue Jul 12, 2021
@albert-github
issue doxygen#7195 reserved identifier violation
3a048d8 
Based in the example in the issue there are a few more files to be handled.
The file winbuild/iconv.h is explicitly not changed as this is an external file.

The change is based on:
- https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29
- https://en.wikipedia.org/wiki/Include_guard#Discussion
@albert-github
Copy link
Collaborator

I've just pushed a proposed patch, pull request #8664

doxygen added a commit that referenced this issue Aug 17, 2021
@doxygen
Merge pull request #8664 from albert-github/feature/issue_7195
5b4058d 
issue #7195 reserved identifier violation
@albert-github albert-github added the fixed but not released Bug is fixed in github, but still needs to make its way to an official release label Aug 17, 2021
@albert-github
Copy link
Collaborator

Code has been integrated in master on GitHub (please don't close the issue as this will be done at the moment of an official release).

@doxygen
Copy link
Owner

doxygen commented Aug 18, 2021

This issue was previously marked 'fixed but not released',
which means it should be fixed in doxygen version 1.9.2.
Please verify if this is indeed the case. Reopen the
issue if you think it is not fixed and please include any additional information
that you think can be relevant (preferably in the form of a self-contained example).

@doxygen doxygen removed the fixed but not released Bug is fixed in github, but still needs to make its way to an official release label Aug 18, 2021
@doxygen doxygen closed this as completed Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
install/build bug in the installation or build scripts
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@elfring @doxygen @albert-github