issue #10240 Multi-line doc not recognized in Python class field #10798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve handling of start of a special comment block. (Looks like it should not be corrected at other places)
|
@albert-github You mention "Looks like it should not be corrected at other places", but I wonder why this is the case. It doesn't look any different from the other 2 cases. |
|
@albert-github I think I already understand it. You basically disabled processing special comments while parsing the function body (they will be picked up while processing individual members). I've now made that more explicit by removing the lexer rule completely. |
albert-github
added
the
fixed but not released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve handling of start of a special comment block. (Looks like it should not be corrected at other places)