Add links behind nav entries "Namespaces" and "Files" (matching "Classes") #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ses") When layout file has "namespacelist" resp. "filelist" set to visible=no, the files "namespaces.html" resp. "files.html" are still generated, but not reachable. So same fix as done for "classlist" should be used, cmp. 700a9ac Also gives consistent result & at least in QCH files fix the error message shown when clicking on "Namespaces" or "Files" section titles.
kossebau
force-pushed
the
makeNavEntriesNamespacesAndFilesLinked
branch
from
135280e
to
464919a
Compare
|
Rebased the commits to latest master, but again Travis dies during
with
Meh. This spoils the otherwise nice idea of CI, if one gets flagged Red only because CI is failing elsewhere :/ All I can say is that locally the patch builds fine and also works as expected for mw :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When layout file has "namespacelist" and/or "filelist" set to visible=no,
the files "namespaces.html" resp. "files.html" are still generated,
but not reachable.
So same fix as done for "classlist" should be used,
cmp. 700a9ac
Also gives a consistent result & at least in generated QCH files fixes the error
message currently shown when clicking on "Namespaces" or "Files" section titles in the navigation tree.
Using lne->baseFile() and thus the string from the central db instead of using a hardcoded duplicated filename feels better, and thus first patch also adapts the code for "LayoutNavEntry::Classes".