Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip was twice 'HTML escaped' #784

Merged

Conversation

albert-github
Copy link
Collaborator

@albert-github albert-github commented Jul 1, 2018

The tooltip was already 'HTML escaped' except for some '<' and '>' characters but was again 'HTML escaped' resulting in e.g. that a single apostrophe (') was translated to &#39; and again to &amp;#39; resulting in &#39; in the tooltip.
Only '<' and '>' are now 'HTML escaped again'

The tooltip was already 'HTML escaped' except for some '<' and '>' characters but was again 'HTML escaped' resulting in e.g. that a single apostrophe (') was translated to &doxygen#39; and again to &amp#39; resulting in &doxygen#39; in the tooltip.
Only '<' and '>' are now 'HTML escaped again'
@doxygen
Copy link
Owner

doxygen commented Jul 5, 2018

Hi Albert, do you have an example of a twice escaped HTML tooltip, as I don't see it like that in the code?

I tried the following with SOURCE_BROWSER = YES:

/** @brief A class with > and < and &. */
class Test {};

@albert-github
Copy link
Collaborator Author

Hi Dimitri,

The description is so that only < and > have to be escaped again and not a character like &.

The example: pull_784_.zip

It is based on: https://stackoverflow.com/questions/43852075/doxygen-parsing-ampersands-for-ascii-chars
Just hover over the functions in the code.

@doxygen doxygen merged commit 1de4faf into doxygen:master Jul 7, 2018
@doxygen
Copy link
Owner

doxygen commented Jul 7, 2018

Looks like the problem is in TextDocVisitor::filter; this produces the unneeded escapes. So I've fixed this instead.

@albert-github albert-github deleted the feature/bug_tooltip_apostrophe branch July 7, 2018 18:14
@albert-github
Copy link
Collaborator Author

Checked against the original problem as well (#378) and this looks still OK as well.

@albert-github albert-github added the fixed but not released Bug is fixed in github, but still needs to make its way to an official release label Jul 7, 2018
@doxygen doxygen removed the fixed but not released Bug is fixed in github, but still needs to make its way to an official release label Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants