Rejects valid stash names and unicode names

[haarg]

While in the perl syntax only certain things are allowed as package, sub, or variable names, internally perl allows (almost) any string to be used as a stash name or glob slot. As Package::Stash is operating on the stash level, it should allow things with nonstandard names to be manipulated just like "normal" names.

Unicode is also properly supported in stash names in perl 5.16+, and works in normal syntax. Removing the check should allow Unicode names to work properly on newer perls. And it would allow them to work as well as manual stash manipulation on older perls.

I can do the work for this, but I'd rather know if it will be accepted first.

[haarg]

Related: doy/package-stash-xs#5 doy/package-stash-xs#3

[karenetheridge]

+1

[dolmen]

👍

[ribasushi]

@doy Any word on this issue? FWIW it is several years old...

[karenetheridge]

Hi Jesse,
would you be interested in sharing comaint on this distribution? I've been shepherding the Moose releases for the last few years with moderate success and I'd be happy to coordinate patch proposals.

[ribasushi]

@haarg @karenetheridge now that P::S moved to Moose can these ship? I still have FIXME's around the area installing P::S...

Also latest still uses https://metacpan.org/source/ETHER/Package-Stash-0.38/Makefile.PL#L99-125, should really move to @Leont's https://metacpan.org/source/ETHER/B-Hooks-EndOfScope-0.24/Makefile.PL#L95-103

[karenetheridge]

yes, let's JFDI. If the changes are sane and well-reviewed and tested I'm happy to do a -TRIAL.

[karenetheridge]

(I can do a Makefile.PL conversion à la BHEOS myself.)

[karenetheridge]

I have comaint on Package::Stash(::(XS|PP)?. Am happy to ship patches. The ExtUtils::HasCompiler switchover will be released shortly.