Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase coverage on ParseStateMachine #25

Closed
doyaaaaaken opened this issue Aug 23, 2019 · 0 comments
Closed

Increase coverage on ParseStateMachine #25

doyaaaaaken opened this issue Aug 23, 2019 · 0 comments
Labels
code quality Upgrade code quality (e.g. refactor, test) good first issue Good for newcomers in progress Something working on currently

Comments

@doyaaaaaken
Copy link
Owner

Test code example.

kotlin-csv/src/test/kotlin/com/github/doyaaaaaken/kotlincsv/parser/CsvParserTest.kt

Line 27 in 84d7f38

parser.parseRow("a,") shouldBe listOf("a", "")

Coverage can be seen here.
https://codecov.io/gh/doyaaaaaken/kotlin-csv/src/master/src/main/kotlin/com/github/doyaaaaaken/kotlincsv/parser/ParseStateMachine.kt
@doyaaaaaken doyaaaaaken added good first issue Good for newcomers code quality Upgrade code quality (e.g. refactor, test) help wanted Extra attention is needed in progress Something working on currently and removed help wanted Extra attention is needed labels Aug 23, 2019
doyaaaaaken added a commit that referenced this issue Aug 25, 2019
@doyaaaaaken
refs #25 Add tests
a7ea069
@doyaaaaaken doyaaaaaken mentioned this issue Aug 25, 2019
Merged
doyaaaaaken added a commit that referenced this issue Aug 25, 2019
@doyaaaaaken
refs #25 improve logic
f90bd5a
doyaaaaaken added a commit that referenced this issue Aug 25, 2019
@doyaaaaaken
refs #25 delete unnecessary logic
c5b16f3
@doyaaaaaken doyaaaaaken mentioned this issue Aug 25, 2019
Merged
doyaaaaaken added a commit that referenced this issue Aug 25, 2019
@doyaaaaaken
Merge pull request #27 from doyaaaaaken/issue-25
2bf0d92 
#25 Increase coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Upgrade code quality (e.g. refactor, test) good first issue Good for newcomers in progress Something working on currently
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@doyaaaaaken