Refactoring about #97 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doyaaaaaken
commented
Aug 7, 2022
| @@ -51,7 +51,7 @@ actual class CsvWriter actual constructor( | |||
| writer.use { it.write() } | |||
| } | |||
|
|
|||
| fun writeString(write: ICsvFileWriter.() -> Unit): String { | |||
| internal fun writeAsString(write: ICsvFileWriter.() -> Unit): String { | |||
There was a problem hiding this comment.
Hide this method for kotlin-csv users to put the internal modifier, because there didn't seem to be many use cases for using this method.
| @@ -144,7 +144,7 @@ actual class CsvWriter actual constructor( | |||
| /** | |||
| * write all rows to string | |||
| */ | |||
| fun writeAll(rows: List<List<Any?>>): String { | |||
| return writeString { writeRows(rows) } | |||
| fun writeAllAsString(rows: List<List<Any?>>): String { | |||
There was a problem hiding this comment.
Rename this method into writeAllAsString because there are many other writeAll methods and their behavior is slightly different from the behavior of this method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #97