Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Notification Event #131

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

blackmo18
Copy link
Contributor

@blackmo18 blackmo18 commented Sep 23, 2023

Closes #129 Allow An Error Interface

Feature Request to allow to listen on what rows are skipped during read all with headers.

This is specially useful for real business use cases where csv data can have erroneous entries, where later business need to correct those entries for re-processing purpose, as well as logging purpose.

@blackmo18 blackmo18 force-pushed the feature/skip-notification-event branch from 64cc0fc to f8f3d5a Compare September 23, 2023 09:15
@doyaaaaaken
Copy link
Owner

@blackmo18
Copy link
Contributor Author

blackmo18 commented Oct 2, 2023

Answered in the following thread.
https://kotlinlang.slack.com/archives/CMAL3470A/p1695392692415329?thread_ts=1691135598.868989&cid=CMAL3470A

currently already using the suggested behavior here

but there a scenario i like to raise

say for we have a file of 100k records, 2 out of 100k in any order, either it exceeds or lacks the required number of headers

  1. Without ignore turned on.
    kotlin-csv only detects the first occurrence and throws an errors and end the processing, altho the there is an error message where row it happened, you will never know the second and so.

  2. With ignore turned on
    we have logging assigned to it, but still there is no direct way of knowing it, or being application aware of it

I agree this scenario is enclosed to specific business logic or requirement, and I agree too, keep it simple.

Tho, on a production ready setup, you dont want always to check info logs looking for missing a data set you want know, you would rather be explicit gathering it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow an error interface channnel
2 participants