Added Test and Function Read with Header From Sequence #43
Conversation
| @@ -50,6 +51,17 @@ class CsvFileReader internal constructor( | |||
| } | |||
| } | |||
|
|
|||
| fun readAllWithHeaderFromSequence( body: CsvHeader.(index: Int, list: List<String>) -> Unit) { | |||
There was a problem hiding this comment.
Exactly, this method signature enables to write clean code by restricting variable scope with block nesting.
https://github.com/doyaaaaaken/kotlin-csv/pull/43/files#diff-d57edaac2d72b352e33e19d683b773b8R225-R231
But, the below method signature would be better because it returned Sequence.
fun readWithHeaderAsSequence(): Sequence<Map<String, String>>
You could handle returned Sequence value like below code. It'd be cleaner and more declarative.
readWithHeaderAsSequence()
.filter { row -> requireNotNull(row["col1"]).toInt() > 0 }
.filter { row -> requireNotNull(row["col2"]) != "hoge" }
.toList()
There was a problem hiding this comment.
Hi,
I also agree with the comment above. As I was looking at the source, the implementation of method fun readAllWithHeader(): List<Map<String, String>> it was initially as a sequence then converted to list.
So I guess, it just needs to be refactored into 2 different methods?
There was a problem hiding this comment.
Simple solution, and I agree with your opinion!
|
Close this PR because it continued on PR #44 . |
#40
Hi this may not be exactly as what the issue, but I think it could serve the same purpose
Kind regards.