Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix promise timeout #120

Merged
merged 2 commits into from
Nov 12, 2018
Merged

Fix promise timeout #120

merged 2 commits into from
Nov 12, 2018

Conversation

RubtsovAV
Copy link
Contributor

see #103

@RubtsovAV
Copy link
Contributor Author

@dozoisch We can not remove the captcha immediately. It is necessary to wait some time when the reset is completed.

PS. In fact, we have no documented way to remove captcha from the page. In this case, we have only one possible way - use delayed removing.

@RubtsovAV
Copy link
Contributor Author

I do not understand what needs to be changed to pass the travis test.

@dozoisch
Copy link
Owner

dozoisch commented Nov 9, 2018

@RubtsovAV it's failing on linter right now. it should be "div" instead of 'div'and "none" instead of 'none'.

You can also run npm run pretty

@RubtsovAV
Copy link
Contributor Author

@dozoisch Done. Thank you!

@dozoisch
Copy link
Owner

@hartzis what do you think? Looks good to me.

@hartzis
Copy link
Collaborator

hartzis commented Nov 12, 2018

Awesome! If it works and cleans up this annoying console error lets do it. Thanks @RubtsovAV and @dozoisch !

@dozoisch dozoisch merged commit 50dcd43 into dozoisch:master Nov 12, 2018
@dozoisch
Copy link
Owner

I’ll release tomorrow morning!

@RubtsovAV
Copy link
Contributor Author

@hartzis Glad to help :)
Thank you for your component!

@dozoisch Awesome!

@dozoisch
Copy link
Owner

v1.0.5!

@hartzis
Copy link
Collaborator

hartzis commented Nov 13, 2018

@dozoisch u have amazing turn around, you are a stellar open source maintainer! u rock!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants