1.0.0 branch PR

[hartzis]

PR to track 1.x branch progress for 1.0.0 release and will close issue #91 when merged. 🎉

• use 1.0.0 react-async-script
• update readme
• update tests
• fill out "skipped" tests for Expired functionality
• add support for the "error-callback" - How to check if the response is successfull #93
  • add tests for error-callback
• only support LTS or soon to be LTS (10) for travis ci
  • https://github.com/nodejs/Release
  • only node 8, 10
• update test runner to jest - update test to use jest #95
  • i think we may be able to do this very easily
  • maybe add enzyme if needed
• update lint and add prettier
• update removeOnMount to removeOnUnmount - react-async-script/api 😸

[hartzis]

@dozoisch if you're able to cut a release candidate from the 1.x branch thad be sweet 😺

[dozoisch]

Perfect! Will cut a @next release

[dozoisch]

@hartzis alright rc.2 should be good =) rc.1 doesn't have the correct build files

[hartzis]

@dozoisch thank you, you rock! It looks like we need to add the same shims we did in react-async-script for the tests, lol. Looks like we also may need to update eslint since it doesn't know how to handle a scoped class correctly 🤣

Also want to update the node versions for travis to match react-async-script

[dozoisch]

Oh wow yeah eslint is old pretty old.. I can update them tomorrow if you want. I'd be down to put prettier in and use like eslint-preset-prettier and be done with codestyle/eslint!

[hartzis]

just a heads up - Working 1.0.0 release candidate - https://codesandbox.io/s/1y4zzjq37l

[hartzis]

well... the tests and lint pass locally. travis seems to be having trouble with node 8/10 with yarn and phantomJS.

This might be the opportunity to update to enzyme/jest? Shouldn't be too bad. may even be able to just do jest and no enzyme and keep the test exactly like they are?

[dozoisch]

Jest is fine with me ! The stacked used here is pretty old 😅😅 so I’m all for modernizing it!

[hartzis]

heads up @dozoisch i think we're supposed to use prepare now.
warnings i get with npm:

npm WARN prepublish-on-install As of npm@5, `prepublish` scripts are deprecated.
npm WARN prepublish-on-install Use `prepare` for build steps and `prepublishOnly` for upload-only.
npm WARN prepublish-on-install See the deprecation note in `npm help scripts` for more information.

[hartzis]

example of npm prepare

https://github.com/reduxjs/react-redux/blob/47facdbcae2412d37d72fa5c37cb4e0cd64a9b4a/package.json#L37

[hartzis]

apologies about the notification spam if it happened, was trying to get the comment code snippet to work, but i don't think it works cross repo...

[dozoisch]

No worries! Alright I'll change it to prepare, good to know.

[dozoisch]

Alright eslint/prettier is done! I'll go do the same in react-async-script

[hartzis]

cut another rc? 😸

[dozoisch]

Will do!

[dozoisch]

Done!

[hartzis]

@dozoisch rc.3 looking good - https://codesandbox.io/s/1y4zzjq37l

we're getting close!

[hartzis]

@dozoisch updated the readme, let me know what you think

• added a link to the codesandbox.io example above
• attempted to make a few things "more clear"?

[hartzis]

last thing is to release 1.0.0 of react-async-script before we cut official 1.0.0 of this

[dozoisch]

awesome work :) I'll check everything tomorrow and cut r-a-s!!

[dozoisch]

@hartzis 🙌 published 1.0.0 on both repos :)! Awesome work