Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read-package-json is a prerequisite for adding the plugin #10

Closed
lasselaakkonen opened this issue Nov 4, 2015 · 2 comments
Closed

read-package-json is a prerequisite for adding the plugin #10

lasselaakkonen opened this issue Nov 4, 2015 · 2 comments

Comments

@lasselaakkonen
Copy link

Adding this plugin runs https://github.com/dpa99c/cordova-custom-config/blob/master/hooks/resolveDependencies.js which tries to install read-package-json, but resolveDependencies.js itself is dependent on read-package-json.

@dpa99c
Copy link
Owner

dpa99c commented Nov 6, 2015

True, but since read-package-json is a dependency of npm, if it's not installed, then either npm isn't installed or it's not installed correctly. But you're right, the plugin doesn't need to try to install a dependency which should already be there.

@dpa99c dpa99c closed this as completed in 43c2c94 Nov 6, 2015
@lasselaakkonen
Copy link
Author

Hmm, yep. Didn't realize it was a dependency of npm. My setup must be somehow wonky, had to install read-package-json separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants