Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when adding cordova-custom-config@3.0.13 #80

Closed
eyalhakim opened this issue Oct 28, 2016 · 5 comments
Closed

Error when adding cordova-custom-config@3.0.13 #80

eyalhakim opened this issue Oct 28, 2016 · 5 comments

Comments

@eyalhakim
Copy link

npm ERR! cordova-custom-config@3.0.13 preinstall: npm install check-node-version && check-node-version --npm ">=3"
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the cordova-custom-config@3.0.13 preinstall script 'npm install check-node-version && check-node-version --npm ">=3"'.

I ran the command myself and it works - returns the current node and npm versions.

Node: 7.0.0
NPM: 4.0.1
Cordova: 6.4.0

Thanks

@eyalhakim
Copy link
Author

I made some progress:

npm install cordova-custom-config

cordova-custom-config@3.0.13 preinstall /Users/eyalhakim/dev/repos/learni-app/node_modules/.staging/cordova-custom-config-986c4b7d
npm install check-node-version && check-node-version --npm ">=3"

check-node-version@1.1.2 node_modules/check-node-version
├── semver@5.3.0
├── run-parallel@1.1.6
└── minimist@1.2.0
node: v7.0.0
npm: v2.15.11
Error: Wanted npm version ">=3" (>=3.0.0)
To install npm, run npm install -g npm@>=3
npm ERR! Darwin 16.1.0
npm ERR! argv "/usr/local/Cellar/node/7.0.0/bin/node" "/usr/local/bin/npm" "install" "cordova-custom-config"
npm ERR! node v7.0.0
npm ERR! npm v4.0.1
npm ERR! code ELIFECYCLE

How is it possible that the output of check-node-version for npm is 2.15.11 when run from the preinstall script whereas when i run check-node-version the output says 4.0.1?
Also, you can see in the log that indeed npm v4.0.1 is running.

@eyalhakim
Copy link
Author

i did every possible reinstallation of node and npm including https://github.com/brock/node-reinstall

@dpa99c
Copy link
Owner

dpa99c commented Oct 29, 2016

Damn it, #79 fixed it for Windows and broke it for OSX. I'm just gonna remove the npm@3 version check and folks will have to just read the documentation.

@dpa99c dpa99c closed this as completed in c07d7f8 Oct 29, 2016
@dpa99c
Copy link
Owner

dpa99c commented Oct 29, 2016

Published to npm as cordova-custom-config@3.0.14

@eyalhakim
Copy link
Author

Great, thank man!

dpa99c added a commit that referenced this issue Nov 23, 2016
Resolves #76 while hopefully not breaking #79 and #80 again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants