docs: readme to suggest edit-config instead of config-file #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config-file sets initial values, then possibly defined by plugins too, and finally edit-config allows to force the final values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the purpose of this PR?
<edit-config>is the proper way to override the usage description messages, not<config-file>.And removes the
platformattribute that does neither exist on<onfig-file>nor on<edit-config>.What testing has been done on existing functionality?
Defining one same
NS*UsageDescriptionwith different values gave me the following results:<config-file>, then inside one or more plugin.xml from installed plugins: the finally applied value is the one from the last plugin 🤔<edit-file>, then inside one or more plugin.xml from installed plugins: the finally applied value is the one from config.xml ✅