Added iOS implementation of switchToNotificationSettings function #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NitroTears
changed the title
NitroTears
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
PR Checklist
For bug fixes / features, please check if your PR fulfils the following requirements:
What is the purpose of this PR?
I have implemented the iOS platform functionality for the existing
switchToNotificationSettingsfunction in the Notifications module, currently only available on Android. On iOS 15.4 or below, the native API to do this was not available, so instead similar to the android implementation, it will take you to the general app settings page instead.Does this PR introduce a breaking change?
What testing has been done on the changes in the PR?
An existing project of mine required the function on both platforms. I have tested it on devices both above and below iOS 15.4.
What testing has been done on existing functionality?
I have have made sure the original android function had not been affected, as I require both for my project.