Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added signInUserWithCustomToken AND signInUserAnonymously auth methods #359

Merged
merged 4 commits into from
Apr 10, 2020
Merged

Added signInUserWithCustomToken AND signInUserAnonymously auth methods #359

merged 4 commits into from
Apr 10, 2020

Conversation

ianitsky
Copy link

@ianitsky ianitsky commented Apr 3, 2020

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation changes
  • Other... Please describe:

PR Checklist

For bug fixes / features, please check if your PR fulfills the following requirements:

  • Testing has been carried out for the changes have been added
  • Regression testing has been carried out for existing functionality
  • Docs have been added / updated

What is the purpose of this PR?

Added signInWithCustomToken and signInAnonymously firebase authentication types.

Does this PR introduce a breaking change?

  • Yes
  • No

What testing has been done on the changes in the PR?

I tested with a real projeto app.fretecorreios.com.
The version with this version of firebasex is only internal yet.
No breaking changes for this PR.

What testing has been done on existing functionality?

I tested with a real projeto app.fretecorreios.com.
The version with this version of firebasex is only internal yet.
No bugsfor this PR.

Other information

@ghost
Copy link

ghost commented Apr 3, 2020

Congratulations 🎉. DeepCode analyzed your code in 1.874 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard

@ianitsky ianitsky changed the title Develop Added signInUserWithCustomToken AND signInUserAnonymously auth methods Apr 3, 2020
@dpa99c
Copy link
Owner

dpa99c commented Apr 10, 2020

Sorry, forgot to review this earlier - really nice PR - thanks @ianitsky

@dpa99c dpa99c merged commit c6b4ecd into dpa99c:master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants