Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Consent Mode v2 (Android & iOS) #878

Merged
merged 18 commits into from
Apr 23, 2024
Merged

Add Consent Mode v2 (Android & iOS) #878

merged 18 commits into from
Apr 23, 2024

Conversation

pinguluk
Copy link

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation changes
  • Other... Please describe:

PR Checklist

Please check your PR fulfills the following requirements:

Bugfixes:

  • Regression testing has been carried out using the example project to ensure the intended bug is fixed and no regression bugs have been inadvertently introduced.

New features/enhancements:

  • Exhaustive testing has been carried out for the new functionality
  • Regression testing has been carried out to ensure no existing functionality is adversely affected
  • Documentation has been added / updated
  • The example project has been update to validate/demonstrate the new functionality.

What is the purpose of this PR?

GA4 now requires consent (EEA)
https://support.google.com/analytics/answer/14275483

Does this PR introduce a breaking change?

  • Yes
  • No

What testing has been done on the changes in the PR?

Forked the firebasex test project and tested the consent functionality
https://github.com/pinguluk/cordova-plugin-firebasex-test

What testing has been done on existing functionality?

Other information

@pinguluk
Copy link
Author

I've also updated iOS sdk to 10.24.0 and bumped up Android sdks versions

@dpa99c
Copy link
Owner

dpa99c commented Apr 19, 2024

Thanks, I'm going to try to make some time next week to merge this and some other PRs, fix some niggling bugs and get a release out

@pinguluk
Copy link
Author

pinguluk commented Apr 23, 2024

Thanks, I'm going to try to make some time next week to merge this and some other PRs, fix some niggling bugs and get a release out

Hey, thanks for your contribution. Can you please check if my modifications are correct? Because I don't really know Objective-c and I had to rely on your previous code, to add the new features.

Also I had to downgrade GoogleSignIn back to 6.2.4, because v7.0.0+ requires some code migration and I don't know exactly what modifications I need to do in the FirebasePlugin.m, to get this to work

@dpa99c dpa99c changed the base branch from master to dev April 23, 2024 13:34
@dpa99c dpa99c merged commit 3ed658e into dpa99c:dev Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants